Bug 384427 - core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp: int / long mixup ?
Summary: core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp: int / long mixup ?
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Bqm-DngConverter (show other bugs)
Version: 5.7.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-06 11:41 UTC by dcb314
Modified: 2021-05-10 20:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.3.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2017-09-06 11:41:32 UTC 
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:269]: (warning) %u 
in format string (no. 1) requires 'unsigned int' but the argument type is 'unsig
ned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:304]: (warning) %u 
in format string (no. 1) requires 'unsigned int' but the argument type is 'unsig
ned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:3584]: (warning) %u
 in format string (no. 1) requires 'unsigned int' but the argument type is 'unsi
gned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:269]: (warning) %u 
in format string (no. 2) requires 'unsigned int' but the argument type is 'unsig
ned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:269]: (warning) %u 
in format string (no. 3) requires 'unsigned int' but the argument type is 'unsig
ned long'.

In general, it is unwise to assume that ints and longs are the same size,
unless this code is for a specific platform & compiler.
Comment 1 caulier.gilles 2017-09-11 09:14:44 UTC 
We will not touch this Adobe DNG SDK source code. It's must be updated in the future.

Gilles Caulier
Comment 2 caulier.gilles 2021-05-10 20:46:07 UTC 
Fixed in 7.3.0 with DNG SDK updated to 1.5