Bug 384423 - core/libs/dngwriter/extra/dng_sdk/dng_string.cpp:2027: confused logic ?
Summary: core/libs/dngwriter/extra/dng_sdk/dng_string.cpp:2027: confused logic ?
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Bqm-DngConverter (other bugs)
Version First Reported In: 5.7.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-06 11:22 UTC by dcb314
Modified: 2021-05-10 20:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 7.3.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2017-09-06 11:22:20 UTC 
digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_string.cpp:2027]: (style) Expression is always false because 'else if' condition matches previous condition at line 2022.

Source code is

               if (b > a)
                    {
                    return 1;
                    }

                else if (a < b)
                    {
                    return -1;
                    }
Comment 1 caulier.gilles 2017-09-06 18:15:07 UTC 
This code come from Adobe DNG SDK.

It's fabulous to see how Adobe code this king of tests...

We don't know how to fix it. We don't write this code. So We must ignore.

Note : in all cases, DNG SDK will be updated as well when Adobe will release a new version.

Gilles Caulier
Comment 2 caulier.gilles 2021-05-10 20:42:32 UTC 
Fixed in 7.3.0 with DNG SDK updated to 1.5