Bug 384422 - core/libs/dngwriter/extra/dng_sdk/dng_mosaic_info.cpp:637: bad if ?
Summary: core/libs/dngwriter/extra/dng_sdk/dng_mosaic_info.cpp:637: bad if ?
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Bqm-DngConverter (other bugs)
Version First Reported In: 5.7.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-06 11:16 UTC by dcb314
Modified: 2021-05-10 20:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 7.3.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2017-09-06 11:16:31 UTC 
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_mosaic_info.cpp:637]: (style) Same expression on both sides of '&&'.

Source code is

  if (mapN && mapS && mapW && mapW)

Maybe better code

  if (mapN && mapS && mapW && mapE)
Comment 1 caulier.gilles 2017-09-11 09:15:20 UTC 
We will not touch this Adobe DNG SDK source code. It's must be updated in the future.

Gilles Caulier
Comment 2 caulier.gilles 2021-05-10 20:42:02 UTC 
Fixed in 7.3.0 with DNG SDK updated to 1.5