Bug 384421 - Bad if condition in source code
Summary: Bad if condition in source code
Status: RESOLVED INTENTIONAL
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Compilation (other bugs)
Version First Reported In: 5.7.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-06 11:13 UTC by dcb314
Modified: 2022-01-02 13:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 7.5.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2017-09-06 11:13:47 UTC 
[digikam-5.7.0/core/libs/dimg/filters/greycstoration/cimg/CImg.h:8792]: (warning) Opposite inner 'if' condition leads to a dead code block.

Source code is

      if (!is_closed && !is_fullscreen) {
        if (is_fullscreen) _desinit_fullscreen();
Comment 1 caulier.gilles 2017-09-06 16:22:39 UTC 
This one can be dropped.

CImg is less an less used in digiKam, and code relevant of this file is never used in fact.

Gilles Caulier