Bug 384001 - Renaming an Activity does not update the Label shown in the Activity Pager
Summary: Renaming an Activity does not update the Label shown in the Activity Pager
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Pager widget (other bugs)
Version First Reported In: 5.10.4
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-25 10:42 UTC by Achim Bohnet
Modified: 2017-12-04 17:24 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Achim Bohnet 2017-08-25 10:42:16 UTC
Reproducde
* configure activity pager to show 'Activity Name'
* Use Activity Manager to rename an Activity
=> Bug1: Labels of Activity name in activity pager is not update
=> Bug2: if name sort order changes, some/all shown Activitieslabel
         don't match the activity in the pager, because the activities
         are sorted, but the shown all shown Names are not updated

E.g.  Activities: Default  & KDE
rename Default to Work: In the activity pager: Default is still shown on the pager and when you klick on KDE, the work activity is shown (and vice versa).

Expected: Activity name is updated in the pager when an activity changes and
if activity order changes in the pager, the name are reordered accordingly.
Comment 1 Kai Uwe Broulik 2017-08-25 10:52:59 UTC
Confirmed. I don't see a signal about activityNamesChanged in KActivities Consumer, though, so this would require some additional plumbing.
Comment 2 Eike Hein 2017-08-26 17:51:27 UTC
CC'ing Ivan to make him aware of the API need.
Comment 3 Achim Bohnet 2017-08-27 10:53:58 UTC
Ah, I see :-(  No 'NameChanged' signal.

But there must be at least and 'activityOrderChanged' signal (see Bug2), because the activity pager reorders activities for the case  actname1 < actname2  changes to act1name1 > act2name.  In this case one has reorder the Names in the same way as the views in the pager.
Comment 4 Eike Hein 2017-10-24 07:04:34 UTC
Ivan, ping?
Comment 5 Ivan Čukić 2017-10-24 07:49:03 UTC
The signal is called KActivities::Info::nameChanged
Comment 6 Eike Hein 2017-10-27 14:49:43 UTC
Patches under review:
https://phabricator.kde.org/D8524
https://phabricator.kde.org/D8525
Comment 7 Eike Hein 2017-12-04 17:24:39 UTC
Git commit 08eec037ce079f5d2412576b7843a6f9ea29a8c9 by Eike Hein.
Committed on 04/12/2017 at 17:24.
Pushed by hein into branch 'master'.

Refresh when the names of the running activities change.

Summary:

Depends on D8524.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8525

M  +13   -5    applets/pager/plugin/pagermodel.cpp

https://commits.kde.org/plasma-desktop/08eec037ce079f5d2412576b7843a6f9ea29a8c9