Bug 384000 - There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B)
Summary: There are two actions (Bold, Add Bookmark) that want to use the same shortcut...
Status: RESOLVED FIXED
Alias: None
Product: kjots
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Stephen Kelly
URL:
Keywords: junior-jobs
: 389489 401212 420974 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-08-25 09:54 UTC by Scarlett Moore
Modified: 2020-05-11 07:52 UTC (History)
5 users (show)

See Also:
Latest Commit: https://commits.kde.org/kjots/ca6f4b963e83ed91cc7314e1b60fe6607b61b53e
Version Fixed In:
Sentry Crash Report:

Attachments
Shutter Software Screen Capture of KJots Warning Message (137.56 KB, image/svg+xml)
2019-02-12 23:21 UTC, Carlen D. Cagle 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Scarlett Moore 2017-08-25 09:54:09 UTC 
on startup I get a warning dialog 'There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B).
Comment 1 JohnPaulding 2017-11-09 18:47:12 UTC 
I get the same. Tried to change bookmark to Ctrl+D but that's reserved for New Book
Comment 2 Christoph Feck 2018-01-29 19:48:20 UTC 
*** Bug 389489 has been marked as a duplicate of this bug. ***
Comment 3 Carlen D. Cagle 2019-02-12 22:59:00 UTC 
Immediately after software launch the following KJots message appears on screen (copied directly from message screen/text):

There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B). This is most probably a bug. Please report it in bugs.kde.org
Comment 4 Carlen D. Cagle 2019-02-12 23:21:50 UTC 
Created attachment 118022 [details]
Shutter Software Screen Capture of KJots Warning Message

Immediately after software launch the following KJots message appears on screen (copied directly from message screen/text):

There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B). This is most probably a bug. Please report it in bugs.kde.org
Comment 5 Carlen D. Cagle 2019-02-12 23:22:11 UTC 
Immediately after software launch the following KJots message appears on screen (copied directly from message screen/text):

There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B). This is most probably a bug. Please report it in bugs.kde.org
Comment 6 Igor Poboiko 2020-04-18 22:06:46 UTC 
Git commit ca6f4b963e83ed91cc7314e1b60fe6607b61b53e by Igor Poboiko.
Committed on 18/04/2020 at 22:06.
Pushed by poboiko into branch 'master'.

[KJots] Fix bookmarks actions

Summary:
This patch ports KJots from deprecated `KBookmarksMenu` API (see {D25660}).

On my machine, it also fixes a crash (`bm_action` was null for some reason,
I did not investigate it though).

It also fixes the shortcuts collision (`action->setShortcut` was not enough,
one also needs to run `actionCollection->setDefaultShortcut`).

Test Plan:
1) Start KJots
2) It don't crash, and `Ambiguous shortcuts` dialog does not appear)
3) Open `Bookmarks` menu, the shortcut is `Ctrl+Shift+B`.

Reviewers: dvratil

Reviewed By: dvratil

Subscribers: winterz, kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D28775

M  +8    -5    src/kjotswidget.cpp

https://commits.kde.org/kjots/ca6f4b963e83ed91cc7314e1b60fe6607b61b53e
Comment 7 Igor Poboiko 2020-04-25 14:57:41 UTC 
*** Bug 401212 has been marked as a duplicate of this bug. ***
Comment 8 Igor Poboiko 2020-05-11 07:52:08 UTC 
*** Bug 420974 has been marked as a duplicate of this bug. ***