Bug 383984 - With Editable location bar turned on, focusing on the location bar and pressing Esc reverts it to breadcrumb mode
Summary: With Editable location bar turned on, focusing on the location bar and pressi...
Status: RESOLVED INTENTIONAL
Alias: None
Product: dolphin
Classification: Applications
Component: bars: location (show other bugs)
Version: 17.08.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-25 00:53 UTC by tguen
Modified: 2018-12-05 00:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tguen 2017-08-25 00:53:21 UTC
Pressing F6 or Ctrl+L to focus on the location bar should set it to editable rather than toggling between editable and breadcrumb. If the config option 'editable location bar' is used, pressing F6 causes it to change to breadcrumb mode so I have to press F6 a second time before I can type a new location. Also pressing Esc when it has focus should not cause it to change to breadcrumb mode.
Comment 1 Nate Graham 2017-09-02 20:03:34 UTC
When Editable Location Bar is set, don't use F6; just just use ctrl+L to focus on it in edit mode.

The issue with the Esc key is a legit bug, though. Renaming and keeping this open to track that.
Comment 2 Nate Graham 2017-09-28 02:20:22 UTC
I've submitted a patch for the Escape key issue: https://phabricator.kde.org/D8021
Comment 3 Nate Graham 2018-11-18 15:52:40 UTC
Patch rejected for reasons that made a lot of sense. I don't think we will change this. It's important for the escape key to be able to make the location bar non-editable again. If you want to keep it editable, just use the tab key to change focus, not the escape key
Comment 4 tguen 2018-12-05 00:45:52 UTC
> Esc is the standard way to return to previous GUI states

It's not returning to a previous state, it's configured not to use this state at all.

It sounds like the patch was rejected but the idea behind it was not.

> This patch disables Esc unconditionally, while it should only do it if 
> the config option is set in Dolphin's or the file dialog's preferences. 
> If it were done that way, I could agree to the patch.

I agree, this would be ideal. Is this possible?