Bug 383916 - Kontact navigator toolbar not right-aligned in KOrganizer parts
Summary: Kontact navigator toolbar not right-aligned in KOrganizer parts
Status: RESOLVED FIXED
Alias: None
Product: kontact
Classification: Applications
Component: calendar (show other bugs)
Version: 5.5.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-23 15:20 UTC by Erik Quaeghebeur
Modified: 2018-07-13 12:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.9.0


Attachments
right-aligned (5.30 KB, image/png)
2017-08-23 15:20 UTC, Erik Quaeghebeur
Details
left-aligned (4.41 KB, image/png)
2017-08-23 15:21 UTC, Erik Quaeghebeur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Quaeghebeur 2017-08-23 15:20:42 UTC
Created attachment 107485 [details]
right-aligned

The navigation toolbar available in Kontact is shown right-aligned for KMail, Akregator, the overview,  Kaddressbook, but left-aligned for the KOrganizer parts (tasks, calendar, journal).

For consistency, one alignment should be used throughout all Kontact-sub-applications. My preference is for it to be right-aligned.
Comment 1 Erik Quaeghebeur 2017-08-23 15:21:12 UTC
Created attachment 107486 [details]
left-aligned
Comment 2 Allen Winter 2017-08-27 16:39:49 UTC
I can reproduce this.
The Navigator toolbar is placed after the Main toolbar, and before the Views toolbar.

At least we need to move the Navigator toolbar after the Views toolbar.
Comment 3 Daniel Vrátil 2018-07-13 12:06:35 UTC
Git commit 4e919b21124e85898c7e3f50faa70b648e132da4 by Daniel Vrátil, on behalf of Denis Kurz.
Committed on 13/07/2018 at 12:05.
Pushed by dvratil into branch 'master'.

Add location hint for Parts' toolbars

Summary:
Fixes the order of toolbars and the orientation of the navigator
toolbar if other toolbars (except the main toolbar) are enabled.
FIXED-IN: 5.9.0

Test Plan:
Enabled various combinations of toolbars in various kontact components.
Navigator toolbar orientation as well as the toolbars' order is broken
iff the navigator toolbar and any toolbar other than the main toolbar
is enabled without the patch. Everything was fine with the patch.

Reviewers: #kde_pim, mlaurent

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D10644

M  +1    -0    src/kontactui.rc

https://commits.kde.org/kontact/4e919b21124e85898c7e3f50faa70b648e132da4