Bug 383751 - Make top navigation back button span up to the leftmost side of Kirigami Gallery window
Summary: Make top navigation back button span up to the leftmost side of Kirigami Gall...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Neon Linux
: NOR wishlist
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-20 11:12 UTC by Alexander Mentyu
Modified: 2018-02-13 22:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
top-navigation-span-to-the-left-side (58.64 KB, image/png)
2017-08-20 11:12 UTC, Alexander Mentyu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mentyu 2017-08-20 11:12:19 UTC
Created attachment 107403 [details]
top-navigation-span-to-the-left-side

Current situation:
When trying to click on empty space between leftmost edge of navigation panel and leftmost edge of back button '<' sign nothing happens.

Desired situation:
Span back button from leftmost edge of back button '<' sign up to the leftmost edge of navigation panel.

Reasoning:
Better UX for desktop users in case when they clicked not exactly on '<' sing - but on empty space to the left side from it. Currently there is only spanning of back button to the right side up to current section's name.
Comment 1 Marco Martin 2017-08-21 08:37:12 UTC
the problem is the existence of an unclickable margin on the left?
Comment 2 Alexander Mentyu 2017-08-21 09:31:13 UTC
Yes, this is small UX issue - but nevertheless - or what do you think?
Comment 3 Marco Martin 2017-08-28 13:47:53 UTC
seems still valid, fixing in kirigami2 (tough this screencast seems to be about kirigami1)
Comment 4 Marco Martin 2017-08-28 14:05:20 UTC
ah, apparently is the left drawer that captures the left-most few pixels so as this is deep in qtquickcontrols2 we can't really do anything about it :/
Comment 5 Marco Martin 2017-08-28 14:06:21 UTC
Git commit 30125a352cc2abccd0807e5dc5ed8ede32768e83 by Marco Martin.
Committed on 28/08/2017 at 14:05.
Pushed by mart into branch 'master'.

better left-lignment for the back button

M  +1    -1    src/controls/templates/ApplicationHeader.qml
M  +9    -4    src/controls/templates/private/BackButton.qml

https://commits.kde.org/kirigami/30125a352cc2abccd0807e5dc5ed8ede32768e83
Comment 6 Alexander Mentyu 2017-08-30 09:53:10 UTC
Can't reproduce anymore in KDE neon - kirigami-gallery 2.2.0+p16.04+git20170830