Bug 383747 - "Rotate only by setting a flag" Changes Image Instead
Summary: "Rotate only by setting a flag" Changes Image Instead
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-Rotation (show other bugs)
Version: 5.6.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-20 10:06 UTC by hardy.public
Modified: 2018-04-15 14:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0
Sentry Crash Report:


Attachments
Rotation Settings (12.07 KB, image/png)
2017-08-20 10:06 UTC, hardy.public
Details
(i) (65.89 KB, image/jpeg)
2017-08-23 16:39 UTC, hardy.public
Details
(ii) (177.41 KB, image/jpeg)
2017-08-23 16:40 UTC, hardy.public
Details
(iii) (177.41 KB, image/jpeg)
2017-08-23 16:40 UTC, hardy.public
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hardy.public 2017-08-20 10:06:23 UTC
Created attachment 107398 [details]
Rotation Settings

If I select "Rotate by only setting a flag" this seems to be the same action as "Rotate by changing the content if possible". It rotates by moving pixels and the flag remains Normal (top, left).

See attached for settings I used.
Comment 1 Maik Qualmann 2017-08-21 17:13:48 UTC
Do you use JPEG or RAW images? I can not reproduce the problem with JPEG images.

Maik
Comment 2 hardy.public 2017-08-23 16:38:31 UTC
I'm using JPEG.

I'll attach 3 images. (i) Before rotation, (ii) after rotation by flag and (iii) after rotation by content.

(ii) and (iii) both have the image rotated and the orientation flag top,left.
Comment 3 hardy.public 2017-08-23 16:39:30 UTC
Created attachment 107487 [details]
(i)
Comment 4 hardy.public 2017-08-23 16:40:09 UTC
Created attachment 107488 [details]
(ii)
Comment 5 hardy.public 2017-08-23 16:40:31 UTC
Created attachment 107489 [details]
(iii)
Comment 6 hardy.public 2017-08-23 16:41:45 UTC
I'll see if it's the same on Ubuntu.
Comment 7 Maik Qualmann 2017-08-23 20:14:18 UTC
When rotating with flag, the file size remains the same. I have debug it, the function to the real rotate is not used. Question: Where do you rotate the image?
 Or do you rotate the image in the image editor?

Maik
Comment 8 hardy.public 2017-08-23 20:35:17 UTC
I used the Image Editor.
Comment 9 hardy.public 2017-08-23 20:36:36 UTC
Did you use the same source image I uploaded, SPACE.JPG?
Comment 10 Maik Qualmann 2017-08-23 20:59:36 UTC
Rotation with flag, is only for the album view and preview image. The Image Editor always creates a new bitmap image.

Maik
Comment 11 hardy.public 2017-08-23 21:03:50 UTC
I see. Thanks for the clarification. Maybe a few words in the settings dialogue may make this clear.
Comment 12 Maik Qualmann 2018-04-15 14:49:19 UTC
Git commit ac3d91d85cbe8f73d9118d0f974624cf5b8da016 by Maik Qualmann.
Committed on 15/04/2018 at 14:48.
Pushed by mqualmann into branch 'master'.

add note to the rotation settings
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +15   -6    core/utilities/setup/metadata/setupmetadata.cpp

https://commits.kde.org/digikam/ac3d91d85cbe8f73d9118d0f974624cf5b8da016