Bug 383743 - Better UX for loading of heavy Kirigami UI elements
Summary: Better UX for loading of heavy Kirigami UI elements
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-20 08:59 UTC by Alexander Mentyu
Modified: 2017-09-14 15:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
long-loading-of-content-in-discover (211.16 KB, video/mp4)
2017-08-20 09:37 UTC, Alexander Mentyu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mentyu 2017-08-20 08:59:04 UTC
Kirigami could detect if loading of particular page/widget could take more than ~150 ms and momentarily display busy indicator at the bottom of such element.
Comment 1 Alexander Mentyu 2017-08-20 09:36:08 UTC
Kirigami is already displaying busy indicator for downloadable content - the wish is to display busy indicator also upon loading of local or cached content - for example loading of 'Applications' section in Discover.
Comment 2 Alexander Mentyu 2017-08-20 09:37:29 UTC
Created attachment 107396 [details]
long-loading-of-content-in-discover
Comment 3 Marco Martin 2017-08-21 07:48:37 UTC
i think it's an issue of discover? is just the application that can know if a page can be potentially problematic to load
Comment 4 Aleix Pol 2017-09-04 14:54:28 UTC
Yes, I don't think we want Kirigami to try to be overly too smart here.

Alexander, do you know why it takes you so long? I've never seen it that slow. If you could do some profiling there that would be very welcome.
Comment 5 Aleix Pol 2017-09-14 15:07:04 UTC
Git commit 349be75c6cab67e389a54ae2c2ce4c893a5d87c1 by Aleix Pol.
Committed on 14/09/2017 at 15:03.
Pushed by apol into branch 'Plasma/5.11'.

Optimize adding resources to the model

Don't reset the model when it starts if it's empty already anyway.
When inserting elements, don't do the cherry-picked insertion unless there
is already things on the view.

M  +7    -4    libdiscover/resources/ResourcesProxyModel.cpp

https://commits.kde.org/discover/349be75c6cab67e389a54ae2c2ce4c893a5d87c1