Bug 383741 - Some sections aren't remembering highlighted state after window height change in Kirigami Gallery
Summary: Some sections aren't remembering highlighted state after window height change...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Neon Linux
: NOR minor
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-20 08:07 UTC by Alexander Mentyu
Modified: 2017-08-30 09:15 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
some-sections-arent-highlighting (561.15 KB, video/mp4)
2017-08-20 08:07 UTC, Alexander Mentyu
Details
some-sections-arent-highlighting-partial (302.01 KB, video/mp4)
2017-08-20 08:28 UTC, Alexander Mentyu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mentyu 2017-08-20 08:07:28 UTC
Created attachment 107392 [details]
some-sections-arent-highlighting

'List View', 'Non Scrollable Page', and 'Colors' sections aren't remembering highlighted state after Kirigami Gallery window height change.
Comment 1 Alexander Mentyu 2017-08-20 08:28:10 UTC
Created attachment 107394 [details]
some-sections-arent-highlighting-partial
Comment 2 Alexander Mentyu 2017-08-20 08:29:21 UTC
Highlighting is remembered with partial height change (some-sections-arent-highlighting-partial video) - but it's not remembered after decreasing height by dragging bottom border of Kirigami Gallery to the very top position possible (or sometimes almost to the very top).
Comment 3 Marco Martin 2017-08-28 14:38:24 UTC
Git commit f71cebb93a96326f95fb09322b6b0b127fee46a8 by Marco Martin.
Committed on 28/08/2017 at 14:33.
Pushed by mart into branch 'master'.

don't store stuff in the delegates

they can be deleted, store the open page on the external listView

M  +5    -2    examples/gallerydata/contents/ui/MainPage.qml

https://commits.kde.org/kirigami/f71cebb93a96326f95fb09322b6b0b127fee46a8
Comment 4 Alexander Mentyu 2017-08-30 09:15:53 UTC
Can't reproduce anymore in KDE neon - kirigami-gallery 2.2.0+p16.04+git20170830