Bug 383603 - [PATCH] Konsole should adopt standard tab switching shortcuts in KStandardShortcut::tabPrev() and KStandardShortcut::tabNext()
Summary: [PATCH] Konsole should adopt standard tab switching shortcuts in KStandardSho...
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: tabbar (show other bugs)
Version: master
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-16 17:26 UTC by Nate Graham
Modified: 2018-12-14 17:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 17.12
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-08-16 17:26:53 UTC
The KDE standard keyboard shortcut for switching tabs was changed to ctrl+pgup/pgdn in https://phabricator.kde.org/D6553. This new shortcut works in Konsole, because ctrl+pgup/pgdn don't send any special shell signals or anything. Therefore, Konsole should adopt the same shortcuts to be consistent with other KDE software (and most software that uses tabs, these days).

This will require a change to ViewManager.cpp, either by changing the shortcut keys, or preferably by adopting KStandardShortcut::tabPrev() and KStandardShortcut::tabNext().
Comment 1 Nate Graham 2017-08-16 17:42:16 UTC
I have created a quick and dirty patch/phabricator diff available at https://phabricator.kde.org/D7354
Comment 2 Albert Astals Cid 2017-08-27 23:01:50 UTC
Git commit 374b602d52447caab9f934e781ae170bd994da7a by Albert Astals Cid.
Committed on 27/08/2017 at 23:01.
Pushed by aacid into branch 'master'.

Add new standard KDE tab switching shortcuts (ctrl+pgup/pgdn)

Summary:

Add the new KDE standard tab switching shortcuts that were introduced in https://phabricator.kde.org/R237:d85a57645f94d2d087711d7c608a0c5a46ed7ede.

Test Plan: Built and tested with current git master in up-to-date KDE Neon. Expected behavior is seen (default shortcuts have become shift+left/right and cmd+pgup/pgdn).

Reviewers: #kde_applications, #konsole, hindenburg, aacid, ltoscano, pino, dfaure

Reviewed By: dfaure

Subscribers: dfaure, davidedmundson, aacid, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D7354

M  +4    -2    src/ViewManager.cpp

https://commits.kde.org/konsole/374b602d52447caab9f934e781ae170bd994da7a