Bug 383530 - DrKonqi has not all Distributions/Platforms that are present on bugs.kde.org site
Summary: DrKonqi has not all Distributions/Platforms that are present on bugs.kde.org ...
Status: RESOLVED FIXED
Alias: None
Product: drkonqi
Classification: Applications
Component: general (show other bugs)
Version: 5.10.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-15 09:19 UTC by Alexander Mentyu
Modified: 2019-07-19 09:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mentyu 2017-08-15 09:19:13 UTC
When reporting bug with DrKonqi - there are selection of Distributions in dropdown list. That list is incomplete compared to Platform list when reporting bug in bugs.kde.org.
Comment 1 Harald Sitter 2019-06-18 15:28:30 UTC
Looks to me this happens because drkonqi doesn't actually query the distributions. This should become solvable once we switch to the new REST api where we can pull the supported values out of `/rest/field/bug`
Comment 2 Harald Sitter 2019-07-19 09:26:27 UTC
Git commit bc83d5ba953bcbce90c72b440173ed49513785c7 by Harald Sitter.
Committed on 19/07/2019 at 09:23.
Pushed by sitter into branch 'master'.

pull platforms/distributions dynamically out of the bugzilla api

Summary:
this ensures that all known platforms are actually in the comobox and
reduces the amount of string duplication.

the new code gets the list of platforms from bugzilla and then either
attempts to select the one which was auto-detected by systeminformation
or recycle the one previously used.

setup is now triggered in the constructor. loading from the api is still
fairly cheap but even so takes longer than the hardcoded list, so
loading this on aboutToShow is fairly unattractive at this point.

the now useless members for combobox state tracking are gone entirely.
CHANGELOG: The list of available platforms is now always in sync with the list on bugzilla itself

Test Plan:
list gets loaded as expected
list errors as expected when offline

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22492

M  +93   -70   src/bugzillaintegration/reportassistantpages_bugzilla.cpp
M  +5    -2    src/bugzillaintegration/reportassistantpages_bugzilla.h
M  +21   -3    src/bugzillaintegration/ui/assistantpage_bugzilla_information.ui

https://commits.kde.org/drkonqi/bc83d5ba953bcbce90c72b440173ed49513785c7