Bug 383491 - KDevPlatformConfig.cmake.in needs clean up
Summary: KDevPlatformConfig.cmake.in needs clean up
Status: RESOLVED FIXED
Alias: None
Product: kdevplatform
Classification: Developer tools
Component: general (show other bugs)
Version: git master
Platform: Other Linux
: NOR task
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2017-08-14 10:29 UTC by Friedrich W. H. Kossebau
Modified: 2018-02-21 16:46 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/kdevelop/86b746ce5325d351d64b83efb8472b0dcd05fdb8
Version Fixed In: 5.3

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2017-08-14 10:29:57 UTC 
All currently dependencies searched for in KDevPlatformConfig.cmake.in need to be rechecked if they really are used in the public kdevplatform API and thus need respective devel packages to be installed by 3rd-party kdevplaform plugin developers.

Downstream thinks there are quite some that could be dropped, e.g. opensuse has a patch: https://build.opensuse.org/package/view_file/KDE:Unstable:Extra/kdevelop5/reduce_dependencies.diff?expand=1

Needs also to be decided which implicitly covered dependencies should be explicitely listed and which not, to protect against future changes in the indirect dependencies.
Comment 1 Aleix Pol 2017-09-05 00:54:49 UTC 
It can probably be trimmed. We just need to list the public dependencies (i.e. in target_link_libraries(...PUBLIC...)) and transcribe it there.

PRIVATE dependencies shouldn't be listed.
Comment 2 Friedrich W. H. Kossebau 2018-02-20 19:48:26 UTC 
Addressing with https://phabricator.kde.org/D10696