Bug 383348 - Single comment tag disappear from syntax/php.xml file
Summary: Single comment tag disappear from syntax/php.xml file
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-10 10:03 UTC by Szyk Cech
Modified: 2020-03-14 15:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Szyk Cech 2017-08-10 10:03:01 UTC
Hi!
I overloaded KSyntaxHighlighting::SyntaxHighlighter::setDefinition in order to get single comment characters from KSyntaxHighlighting::Definition::filePath() file. I need this in order to make easier comment/uncomment code in my editor. For most files it works as expected, but it fail for php file definition. Surprisingly it this file in source directory has single line comment! But I discovery, that file in KF5SyntaxHighlighting.dll is different!

My opinion is that php.xml given from KF5SyntaxHighlighting.dll should have single comment as it have in sources.

thanks and regards
Szyk Cech
Comment 1 Christoph Cullmann 2020-03-14 15:38:26 UTC
Hmm, the php.xml is packed into the library 1:1.

There are a few syntax files generated, that e.g. include PHP, like html-php.xml, they have different comment directives, but they match their main language.

Btw., the library has no accessors in Definition to get the comment markers.