Bug 383182 - placesitem.cpp typo in PlacesItem::updateBookmarkForRole("udi")
Summary: placesitem.cpp typo in PlacesItem::updateBookmarkForRole("udi")
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: places (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-06 00:09 UTC by Chris Holland
Modified: 2017-08-23 10:55 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/dolphin/24baf24f5fe089302850c7844f1ecdfd60fbb0f1
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Holland 2017-08-06 00:09:37 UTC 
While skimming this code I noticed "udi)" had an extra ). I assume that's a typo making PlacesItem::updateBookmarkForRole("udi") do nothing.

https://github.com/KDE/dolphin/blame/f38960e034cf622bc87575e91014404e8128f120/src/panels/places/placesitem.cpp#L319

I've no idea under what conditions udi would change and if there's any reported bugs it might affect.
Comment 1 Christoph Feck 2017-08-23 10:55:03 UTC 
Git commit 24baf24f5fe089302850c7844f1ecdfd60fbb0f1 by Christoph Feck.
Committed on 23/08/2017 at 10:53.
Pushed by cfeck into branch 'master'.

Fix typo in udi string

Spotted by Chris Holland.

M  +1    -1    src/panels/places/placesitem.cpp

https://commits.kde.org/dolphin/24baf24f5fe089302850c7844f1ecdfd60fbb0f1