Bug 383157 - Desktop Effects - Preview error makes System Settings unresponsive
Summary: Desktop Effects - Preview error makes System Settings unresponsive
Status: RESOLVED NOT A BUG
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: 5.10.4
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-05 04:49 UTC by Brennan Kinney
Modified: 2017-08-06 14:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brennan Kinney 2017-08-05 04:49:08 UTC
The video/animated preview buttons when in System Settings -> Desktop Behaviour -> Desktop Effects.

Clicking the button gets you a spinning loading indicator, and then sometimes(Looking Glass for example) it's just blank. I guess the video/preview failed to load or no long existed? Whatever the current format is, adding some GIFs here locally to avoid the loading time(5-10 seconds here) should be small on size and give an improved UX. 

The expanded list item doesn't seem to have an intuitive way to collapse back to how it was prior to the preview(clicking the video button again or another list item doesn't collapse). 

Playing with this just now actually froze up System Settings, it became unresponsive, a warning dialog to terminate the window popped up but it's buttons to take action are also unresponsive...which in turned popped up a dialog to kill the unresponsive dialog to kill system settings...also unresponsive, I sent a kill signal to system settings process to resolve. Perhaps the failed video for the effect caused the breakage. 

I can reproduce this with the "Looking Glass" effect. Press the video preview button, wait 10 seconds or so for the spinner to disappear, should be no preview(blank output), click the same video preview button again, it'll go grey and the window will become unresponsive. You can resolve by killing the system settings process, doing this a few times on nvidia seems to have killed compositing too..

The "Looking Glass" effect actually doesn't seem to work for me at all when I've tried it. I also haven't gone through each effect to try the preview button so others may also be affected.

---

To summarize
- Previews for some effects are invalid and causing errors (remote content doesn't exist or is unreachable?), unresponsive window happens when using the preview button twice for an effect, using a different effect preview button is fine.
- Local animated GIFs or similar instead of remotely(I'm assuming they're remotely sourced..) sourcing the preview would be nice, 5-10 sec delay, especially for content that doesn't seem to exist is bad UX. Something might be wrong with my install, as no previews seem to be working, but they were fine on my friends fresh install as far as I can recall the other day(eg Wobbly Windows or Zoom).
- The active item in the list does not collapse it's preview window(assuming it's like the info button, clicking the preview button should do this. It will collapse if scrolled far enough out of view.
Comment 1 Martin Flöser 2017-08-06 14:58:37 UTC
Please create one bug per issue. You created:
* a feature request to show animated gif
* a bug about preview being just black
* a bug about the UI not collapsing
* a bug about a freeze

It's great that you report all these issues but we can only properly track and fix all of them if we have one bug report per issue. If I fix the first issue what would be the state of this bug? Due to that I have to set this bug as INVALID and kindly ask to report a bug report for each of the issues.

Please stick to a format of:
Steps to reproduce:
1. I did this
2. I did that
3. then I did the following

Expected result:
Video plays

Actual result:
black preview