Bug 383059 - Inline editing tools have black icons on a gray background
Summary: Inline editing tools have black icons on a gray background
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: 16.12.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-02 18:50 UTC by miklos
Modified: 2017-09-29 18:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot.png (108.97 KB, image/png)
2017-08-02 18:50 UTC, miklos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description miklos 2017-08-02 18:50:09 UTC
Created attachment 107044 [details]
screenshot.png

See the attached screenshot of Fedora 26 live system in VirtualBox.
Comment 1 Christoph Feck 2017-08-02 19:09:10 UTC

*** This bug has been marked as a duplicate of bug 374581 ***
Comment 2 miklos 2017-08-02 19:11:47 UTC
The icons are not missing. They are black on dark grey background.
Comment 3 Nate Graham 2017-09-08 17:44:04 UTC

*** This bug has been marked as a duplicate of bug 374581 ***
Comment 4 Nate Graham 2017-09-08 17:44:42 UTC
Actually you're right. They aren't missing, the contrast is just bad.
Comment 5 Nate Graham 2017-09-26 04:45:05 UTC
Patch available at https://phabricator.kde.org/D7988
Comment 6 Nate Graham 2017-09-27 18:40:15 UTC
Git commit b09b216fe7b404dfc12f78834c38f4a0793a5d4d by Nathaniel Graham.
Committed on 27/09/2017 at 18:38.
Pushed by ngraham into branch 'Applications/17.08'.

Use standard QToolButtons so that their icons use the right colors

Summary:

For the inline context buttons, use the standard QToolButton widget which respects theming so that icons are always visible

Test Plan:
Tested in KDE Neon with Breeze light and dark, Oxygen, and all default color schemes. Big improvement.

Current with Breeze:
{F4047019}

Patched version with Breeze:
{F4103061}

Patched version with Breeze Dark:
{F4103078}

Reviewers: #kde_applications, vtasoulas, broulik, rkflx

Reviewed By: rkflx

Subscribers: mart, rkflx

Differential Revision: https://phabricator.kde.org/D7988

M  +0    -2    app/org.kde.gwenview.appdata.xml
M  +11   -0    lib/thumbnailview/contextbarbutton.cpp
M  +11   -0    lib/thumbnailview/contextbarbutton.h
M  +11   -6    lib/thumbnailview/previewitemdelegate.cpp
M  +5    -4    lib/thumbnailview/thumbnailbarview.cpp

https://commits.kde.org/gwenview/b09b216fe7b404dfc12f78834c38f4a0793a5d4d
Comment 7 null 2017-09-29 18:50:35 UTC
Git commit 46e95531c731bd0a3a325ad5fc178e5256d29f0c by Henrik Fehlauer.
Committed on 29/09/2017 at 18:49.
Pushed by rkflx into branch 'Applications/17.08'.

Fix icon colors of inline context buttons also in full screen mode

Summary:
In the darker full screen mode, the icons of the mouse-over overlays
were still hard to see against the similarly coloured background. This
was because when switching to full screen mode, we would miss to reset
the icon (except for `mToggleSelectionButton`). The root cause is
`QAbstractButton`, which just holds onto a pixmap and has no way of
knowing `KIconLoader` would return a differently coloured icon when the
colour palette changes (as is the case for colour-aware icon sets like
"Breeze").

To fix this, we simply use `QIcon::fromTheme` instead of `SmallIcon`,
which returns a proper `QIcon` instead of a `QPixmap` and automatically
adapts to colour palette changes.

(This is a followup patch to D7988.)
FIXED-IN: 17.08.2

Test Plan:
Overlay icons perfectly visible against the background color in standard
and full screen mode. Tested with "Breeze" and "Breeze Dark" colour
schemes as well as "Breeze", "Oxygen" and "Fusion" widget styles.
("Fusion" does not allow to customize the size for small icons, though.)

Reviewers: #kde_applications, broulik, ngraham

Reviewed By: broulik

Differential Revision: https://phabricator.kde.org/D8031

M  +2    -2    lib/datewidget.cpp
M  +6    -6    lib/thumbnailview/previewitemdelegate.cpp
M  +2    -2    lib/thumbnailview/thumbnailbarview.cpp

https://commits.kde.org/gwenview/46e95531c731bd0a3a325ad5fc178e5256d29f0c