Bug 382992 - Missing dependencies in cmake?
Summary: Missing dependencies in cmake?
Status: RESOLVED NOT A BUG
Alias: None
Product: filelight
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Martin Sandsmark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-01 09:39 UTC by Yuri
Modified: 2018-07-21 13:42 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri 2017-08-01 09:39:15 UTC 
CMakeLists only lists these dependencies:
find_package(Qt5 5.4 CONFIG REQUIRED Core Widgets)
find_package(KF5 REQUIRED
    XmlGui # For app
    KIO # For part
    DocTools
    I18n
)

The FreeBSD port builder finds that this list of actual dependencies:
USE_KDE=        ecm codecs kio doctools jobwidgets auth i18n config configwidgets completion coreaddons service xmlgui widgetsaddons
USE_QT5=        core gui network widgets dbus xml qmake_build

I think, several items should be added to cmake list, like Gui, Network, DBus, etc.
Comment 1 Christoph Feck 2017-08-23 00:39:57 UTC 
The packages you listed are dependencies of KF5::XmlGui and KF5::KIO, but probably not used directly by filelight.
Comment 2 Martin Sandsmark 2018-07-21 13:42:15 UTC 
yeh, those are not our dependencies (except ECM, which is found above in the cmakelists.txt), so the current behavior is correct.