Bug 382920 - klauncher uses absolute compile time install path for finding kioslave.exe
Summary: klauncher uses absolute compile time install path for finding kioslave.exe
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kinit
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.36.0
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks: 380136
  Show dependency treegraph
 
Reported: 2017-07-30 07:12 UTC by Ralf Habacker
Modified: 2018-04-04 10:18 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.40.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2017-07-30 07:12:24 UTC
klauncher uses CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 on Windows and Mac to find kioslave executable (see https://cgit.kde.org/kinit.git/tree/src/klauncher/klauncher.cpp#n1072 and https://cgit.kde.org/kinit.git/tree/src/klauncher/klauncher.cpp#n1098).

This does not work at least on Windows where the runtime path of  kioslave.exe does not match the compile time path

Because on Windows kioslave.exe lives in the same directory as klauncher and the Windows api searches in this directory the solution is to remove any path from the requested executable string and let KProcess find it.
Comment 1 Ralf Habacker 2017-12-20 09:35:25 UTC
review request https://phabricator.kde.org/D7707