Bug 382855 - Middle click on QSystemTrayIcon сauses context menu
Summary: Middle click on QSystemTrayIcon сauses context menu
Status: RESOLVED FIXED
Alias: None
Product: plasma-integration
Classification: Plasma
Component: general (show other bugs)
Version: 5.10.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Martin Flöser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-28 13:26 UTC by Sergey V Turchin
Modified: 2017-11-29 22:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
fix (511 bytes, patch)
2017-07-28 13:26 UTC, Sergey V Turchin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey V Turchin 2017-07-28 13:26:27 UTC
Created attachment 106921 [details]
fix

Middle-click on QSystemTrayIcon сauses context menu.
Comment 1 Martin Flöser 2017-07-29 17:33:01 UTC
could you please post the patch on phabricator.kde.org which we use for patch review? This needs to be looked at by devs familiar with SNI, which I am not.
Comment 2 Sergey V Turchin 2017-07-31 09:16:03 UTC
https://phabricator.kde.org/D7013
Comment 3 David Edmundson 2017-08-09 19:09:00 UTC
Git commit b0059b1c8342b5ef95b054a0a5081b5db7e1c7bb by David Edmundson, on behalf of Sergey V Turchin.
Committed on 09/08/2017 at 19:08.
Pushed by davidedmundson into branch 'master'.

Middle-click on QSystemTrayIcon сauses context menu

Summary:
Middle-click on QSystemTrayIcon сauses context menu because inconstant with
http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/dbustray/qstatusnotifieritemadaptor.cpp?h=5.7#n177
QStatusNotifierItemAdaptor::SecondaryActivate()

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: cfeck, davidedmundson, McPain

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7013

M  +1    -1    src/platformtheme/kdeplatformsystemtrayicon.cpp

https://commits.kde.org/plasma-integration/b0059b1c8342b5ef95b054a0a5081b5db7e1c7bb
Comment 4 RJVB 2017-11-29 22:12:04 UTC
Git commit abdc4c0013a4dfb8e52faf4883e63315b05ca6ca by R.J.V. Bertin.
Committed on 29/11/2017 at 21:27.
Pushed by rjvbb into branch 'qt590'.

Probably moot: Middle-click on QSystemTrayIcon сauses context menu

Summary:
Middle-click on QSystemTrayIcon сauses context menu because inconstant with
http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/dbustray/qstatusnotifieritemadaptor.cpp?h=5.7#n177
QStatusNotifierItemAdaptor::SecondaryActivate()

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: cfeck, davidedmundson, McPain

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7013

cherry-picked from plasma-integration: b0059b1c8342b5ef95b054a0a5081b5db7e1c7bb
Committed from host : Portia.local

M  +1    -1    src/platformtheme/kdeplatformsystemtrayicon.cpp
M  +1    -0    src/platformtheme/plintegration-cumpatch1.diff

https://commits.kde.org/osx-integration/abdc4c0013a4dfb8e52faf4883e63315b05ca6ca