Bug 382834 - LockScreenUi.qml uses easing and not easing.type on line 98
Summary: LockScreenUi.qml uses easing and not easing.type on line 98
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Theme packages (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-28 02:29 UTC by David Greengas
Modified: 2017-08-14 16:24 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Proposed Patch (718 bytes, patch)
2017-07-28 20:38 UTC, David Greengas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Greengas 2017-07-28 02:29:38 UTC
I was trying to test an issue with the lockscreen wallpaper and I was using the kscreenlocker_greet --testing to test the lock screen. On the console output I noticed the line "Unable to assign int to QEasingCurve." After searching online, I noticed that the field easing should be easing.type on line 98 of  
root/lookandfeel/contents/lockscreen/LockScreenUi.qml of the plasma-workspace project.

I changed it from:
PropertyAnimation { id: stateChangeAnimation; properties: "y"; duration: 300; easing: Easing.InQuad}

to:

PropertyAnimation { id: stateChangeAnimation; properties: "y"; duration: 300; easing.type: Easing.InQuad}

The error went away and I actually saw an animation.

I did not see a placeholder for plasma-workspace in the bug report.

Let me know if you need me to create a diff for this. I also saw this as part of org.kde.breeze.desktop package in my plasma/look-and-feel directory. I am guessing that this is the origin of this file.
Comment 1 Martin Flöser 2017-07-28 04:44:25 UTC
Yes a patch would be great. It's in plasma-workspace git repository.
Comment 2 David Edmundson 2017-07-28 13:13:46 UTC
For uploading diffs, please follow:

https://community.kde.org/Infrastructure/Phabricator

Message if you get stuck or visit #plasma on Freenode.
Comment 3 David Greengas 2017-07-28 20:38:08 UTC
Created attachment 106930 [details]
Proposed Patch
Comment 4 David Edmundson 2017-07-29 14:40:32 UTC
Git commit 1511e486ae46789a34506461f2847d4a37f605cc by David Edmundson, on behalf of David Greengas.
Committed on 29/07/2017 at 14:39.
Pushed by davidedmundson into branch 'Plasma/5.10'.

Use correct easing type values

Summary:

Per the QML specification, the animation Easing.InQuad should be specified with easing.type, not easing.

Test Plan:
run kscreenlocker --testing

The console output should not display a warning about the animation.

Reviewers: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6970

M  +1    -1    lookandfeel/contents/lockscreen/LockScreenUi.qml

https://commits.kde.org/plasma-workspace/1511e486ae46789a34506461f2847d4a37f605cc