Bug 382783 - "Save" after "Apply Difference" or "Apply All" because of empty destination
Summary: "Save" after "Apply Difference" or "Apply All" because of empty destination
Status: REPORTED
Alias: None
Product: kompare
Classification: Applications
Component: general (show other bugs)
Version: 4.1.3
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kompare developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-27 07:45 UTC by Gregor Mi
Modified: 2017-07-27 09:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gregor Mi 2017-07-27 07:45:41 UTC
1) I downloaded a patch from review board.
2) I placed it into the root of the checked out source tree
3) I clicked it => opens with kompare
4) I clicked the "Apply All" button and then "Save"

The message box appears:
```
Could not upload the temporary file to the destination location . The temporary file is still available under: /tmp/kompare.S10378. You can manually copy it to the right place.
```

and on the console:
```
libkomparediff: KompareModelList::saveDestination: 
libkomparediff: Tempfilename   :  "/tmp/kompare.n10197"
libkomparediff: DestinationURL :  QUrl("")
kf5.kio.core: Refilling KProtocolInfoFactory cache in the hope to find ""
kf5.kio.core: Refilling KProtocolInfoFactory cache in the hope to find ""
kf5.kio.core: Invalid URL: QUrl("")
libkomparediff: true or false? false
```

I wonder if this has something to do with the fact that the Destination Folder is "Unknown" and if yes how this could be changed. Or did I use kompare the wrong way?
Comment 1 Kevin Kofler 2017-07-27 08:56:02 UTC
You are indeed trying to do something that is not supported. The Apply feature works only if you compare files from within Kompare, not if you load an already premade diff.
Comment 2 Gregor Mi 2017-07-27 09:10:46 UTC
Ah, thanks :).

1) Do the Apply buttons currently have any other use in this case?

2) Without any deeper knowledge of the program: would the implementation of this feature be much more complicated than adding the correct Destination URL when the diff file is loaded?