Bug 382776 - Keep "Apply" button greyed out until some setting is changed
Summary: Keep "Apply" button greyed out until some setting is changed
Status: REPORTED
Alias: None
Product: k3b
Classification: Applications
Component: GUI/Usability (show other bugs)
Version: 23.04.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: k3b developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-27 05:06 UTC by Patrick Silva
Modified: 2023-05-13 17:03 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-07-27 05:06:43 UTC
"Apply" button from the settings window is always enabled.
I think my summary describes the correct behavior.
Comment 1 Leslie Zhai 2017-07-27 07:35:27 UTC
Git commit 83a00a9aa0e362d8a99d1b28a5d49aaaf3df7ad0 by Leslie Zhai.
Committed on 27/07/2017 at 07:33.
Pushed by lesliezhai into branch 'master'.

Implement enable "apply" button only when some setting is changed.

But there are too many widgets had been connect with changed SIGNAL..

M  +2    -0    src/option/k3bmiscoptiontab.cpp
M  +3    -0    src/option/k3bmiscoptiontab.h
M  +4    -0    src/option/k3boptiondialog.cpp

https://commits.kde.org/k3b/83a00a9aa0e362d8a99d1b28a5d49aaaf3df7ad0
Comment 2 Patrick Silva 2017-08-12 16:16:22 UTC
What is the status of this bug?
Comment 3 Leslie Zhai 2017-08-15 05:05:46 UTC
(In reply to Dr. Chapatin from comment #2)
> What is the status of this bug?

much lower priority than BUG 382941
Comment 4 Patrick Silva 2017-12-14 23:58:00 UTC
K3b 17.12 changelog says that this issue is solved.
It's not true.
Comment 5 Leslie Zhai 2017-12-15 00:41:38 UTC
(In reply to Dr. Chapatin from comment #4)
> K3b 17.12 changelog says that this issue is solved.
> It's not true.

https://github.com/KDE/k3b/blob/master/ChangeLog#L3

Changes, not Bugfixes :)


https://github.com/KDE/k3b/blob/master/ChangeLog#L12

Implemented enable "apply" button only when some setting is changed.

Hi Nate Graham,
But it is only skeleton, welcome patch to save the changes when clicked "apply" button. thanks a lot!
Comment 6 Nate Graham 2017-12-16 17:37:18 UTC
Sorry, I'm afraid I can't contribute much to K3b as I don't have any hardware with a disc drive.
Comment 7 Leslie Zhai 2017-12-17 01:20:39 UTC
(In reply to Nate Graham from comment #6)
> Sorry, I'm afraid I can't contribute much to K3b as I don't have any
> hardware with a disc drive.

Never mind :) I don't have any hardware neither but use CDEmu instead https://www.leetcode.cn/2016/08/k3b.html#test