If you group items and you have metadata group edit enabled rating a group only works if you use the shortcuts (ctrl 0-5). If you use the mouse to change the stars of a group only the first item in the group gets rated. This is serious imo because you will get metadata inconsistency if you use your mouse to change a rating.
Created attachment 106845 [details] Considers grouping for rating applied via overlay
@Gilles, Maik, ...: Good to go? It fixed the bug for me. Just to try out how it works I also posted this on phabricator: https://phabricator.kde.org/D6962 You can either ignore it (should be closed automatically once committed) or use it to comment on the code.
Patch work fine for me, commit it. Maik
Git commit 0c7e25df54de368a8cd5f309380c6bbb1d659d51 by Simon Frei. Committed on 29/07/2017 at 15:07. Pushed by sfrei into branch 'master'. grouping: Fix setting rating via overlay Requires new functionality to check for grouping for specific model indexes instead of currently selected ones. To that end some refactoring was necessary, but existing function signatures have not changed. FIXED-IN: 5.7.0 M +7 -16 app/items/digikamimageview.cpp M +0 -2 app/items/digikamimageview.h M +69 -49 app/items/imagecategorizedview.cpp M +11 -1 app/items/imagecategorizedview.h https://commits.kde.org/digikam/0c7e25df54de368a8cd5f309380c6bbb1d659d51
Git commit 615b18b591ce199b392cbc0b0f2cbe90d47b09a2 by Ahmed Fathi Shaban, on behalf of Simon Frei. Committed on 06/08/2017 at 23:14. Pushed by ahmedfathy into branch 'gsoc17-dlna'. grouping: Fix setting rating via overlay Requires new functionality to check for grouping for specific model indexes instead of currently selected ones. To that end some refactoring was necessary, but existing function signatures have not changed. FIXED-IN: 5.7.0 M +7 -16 app/items/digikamimageview.cpp M +0 -2 app/items/digikamimageview.h M +69 -49 app/items/imagecategorizedview.cpp M +11 -1 app/items/imagecategorizedview.h https://commits.kde.org/digikam/615b18b591ce199b392cbc0b0f2cbe90d47b09a2