Bug 382650 - Wrong Icon to Remove User in User Manager Settings
Summary: Wrong Icon to Remove User in User Manager Settings
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.8.4
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-24 10:06 UTC by francesco.rigotti
Modified: 2018-02-02 12:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of the dialog (43.66 KB, image/png)
2017-07-24 10:06 UTC, francesco.rigotti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description francesco.rigotti 2017-07-24 10:06:29 UTC
Created attachment 106822 [details]
Screenshot of the dialog

I believe that the remove button should have a 'minus' icon (opposite of 'plus' for the add button) instead of a 'forbidden' icon
Comment 1 David Edmundson 2017-07-28 14:43:50 UTC
We use the icon list-remove, which is the opposite of list-add.

From a code POV it's right, I'll forward this to the icon people to have an opinion on whether the icon is correct
Comment 2 francesco.rigotti 2017-08-02 08:24:30 UTC
(In reply to David Edmundson from comment #1)
> We use the icon list-remove, which is the opposite of list-add.
> 
> From a code POV it's right, I'll forward this to the icon people to have an
> opinion on whether the icon is correct

Thank you for checking this out.

Indeed the code is right, but I find the icon misleading.

list-remove-user is very clear, but then the add button should be updated to the counterpart list-add-user.
Comment 3 andreas 2018-02-02 12:51:02 UTC
Git commit b0cf5f30406caa40a1a765e7a21c3ced0d403578 by andreas kainz.
Committed on 02/02/2018 at 12:55.
Pushed by andreask into branch 'master'.

Update list-remove icon with - instead cancel icon

M  +4    -7    icons-dark/actions/16/list-remove.svg
M  +10   -3    icons-dark/actions/22/list-remove.svg
M  +3    -7    icons-dark/actions/24/list-remove.svg
M  +4    -7    icons/actions/16/list-remove.svg
M  +10   -3    icons/actions/22/list-remove.svg
M  +3    -7    icons/actions/24/list-remove.svg

https://commits.kde.org/breeze-icons/b0cf5f30406caa40a1a765e7a21c3ced0d403578