Created attachment 106820 [details] screenshot showing missing integration Hi, from user point of view, it is difficult to share an image, although a button for sharing exists. There are no options, for instance sending by mail is not possible. Best regards Enrico
The sharing button currently image exporters provided by kipi-plugins. Perhaps we should move to using the Purpose framework, which provides more options, including a "send by email" option.
> email integration - thunderbird does not appear in the sharing options Installing kipi-plugins (not sure how the package is called in Debian) should populate the menu. However, the actual plugin you'll want is accessed via the menu: Plugins → Tools → Email Images… (make sure to select Thunderbird in the "Mail program" combobox). > Perhaps we should move to using the Purpose framework Does this have the same features as the kipi-plugin for sharing via email? (Specifying max. image size, downscale images, split into multiple mails, …)
You're right, the Purpose one is more limited. So I guess it makes sense to keep this using kipi-plugins, but we need to make the Share button shows the email plugin, not only the Export plugins.
We might have to just special-case adding it (if present) in kipiexportaction.cpp
If you have a KDE4 installation handy, check out the Export menu (same as the share button). "Email Images" is right on top. Somehow this was changed (and I got angry users not finding the button anymore). However, before changing it back _again_ and causing even more confusion, we'd need to understand who made the change and why (time to get out your git blame). Maybe it was by accident, maybe it was intentional. (I believe we lost a lot of entries in the transition to KF5, too.)
Browsing the code in kipiexportaction.cpp, the Share button only displays plugins marked as Export plugins. "Email Images..." isn't an Export plugin, it's a Tools plugin. In fact, it seems to be the only one there... Perhaps we could solve this if simply change the category of the "Email Images..." plugin.
There's also a related problem exposed in the screenshot: The Share button doesn't prompt you to install kipi-plugins if it's not installed. The Plugins menu does, though; we should re-use that for the Share menu. To track this, I've filed https://bugs.kde.org/show_bug.cgi?id=386753
Could you find the commit were "Email Images" lost the Export capability? (My second guess would be that Export was added later and forgotten to be added to "Email Images", but there should be commits too for adding Export.)
dev@dev-pc:~/repos/kipi-plugins/sendimages$ git blame ./plugin_sendimages.cpp | grep -i tools b776cb45 sendimages/plugin_sendimages.cpp (Gilles Caulier 2016-08-19 13:02:51 +0200 112) setDefaultCategory(ToolsPlugin); https://cgit.kde.org/kipi-plugins.git/commit/?id=b776cb45fbd2c0f97fac71e04a5f08362e1a3ca0 That doesn't seem like it was the right call. I'll prepare a patch to move it back to Export, which is a much better fit than the "post-processing" category.
Patch available at https://phabricator.kde.org/D8762
Git commit 647ad063846b00049a6ec5dfa9e3e87e53d18801 by Nathaniel Graham. Committed on 16/11/2017 at 04:46. Pushed by ngraham into branch 'master'. Move sendImages plugin back to the Export category Summary: Moved the SendImages ("Email Images...") plugin back to the Export category, which is a more appropriate place for it than Tools. This also fixes 382647. Test Plan: Tested in KDE Neon. The plugin is now in the Export category, and hence appears correctly in Gwenview's Share button: {F5487391} Reviewers: rkflx, mqualmann, cgilles Subscribers: cgilles Differential Revision: https://phabricator.kde.org/D8762 M +1 -1 sendimages/kipiplugin_sendimages.desktop.cmake.in M +3 -3 sendimages/kipiplugin_sendimagesui.rc M +1 -1 sendimages/plugin_sendimages.cpp https://commits.kde.org/kipi-plugins/647ad063846b00049a6ec5dfa9e3e87e53d18801