Bug 382629 - Filter and Search delivers wrong results for text search in aspect ratio
Summary: Filter and Search delivers wrong results for text search in aspect ratio
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Filters (show other bugs)
Version: 8.3.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-23 18:29 UTC by Orloff34
Modified: 2024-07-11 09:35 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.4.0
Sentry Crash Report:


Attachments
Screenshot with search string and results (149.25 KB, image/jpeg)
2017-07-23 18:29 UTC, Orloff34
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Orloff34 2017-07-23 18:29:02 UTC
Created attachment 106804 [details]
Screenshot with search string and results

Search and Filter delivers incorrect results if pictures have portrait aspect ratio.
Pictures in landscape aspect ratio having 3:2 or 4:3 and text search or filter deliver the correct results for search strings "3:2" or "4:3". Pictures in portrait aspect ration are not found using these search strings.

If the pictures are in portrait must be searched with the strings "2:3" or "3:4" which for me is not logic and the search delivers all pictures in portrait independent from the value.

Bug is present in 4.14.0 and 5.5.0
Comment 1 caulier.gilles 2020-08-04 08:24:25 UTC
digiKam 7.0.0 stable release is now published:

https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/

We need a fresh feedback on this file using this version.

Best Regards

Gilles Caulier
Comment 2 caulier.gilles 2022-01-10 11:32:20 UTC
Hi Orloff and happy new year

Please try using current digiKam 7.5.0 pre-release bundle available here :

https://files.kde.org/digikam/

Thanks in advance

Gilles Caulier
Comment 3 caulier.gilles 2023-04-22 06:27:50 UTC
@Orloff34

digiKam 8.0.0 is released. This file still valid ?

Gilles Caulier
Comment 4 caulier.gilles 2023-10-12 05:49:26 UTC
Orloff34,

What's about this file using current 8.2.0 AppImage Linux bundle ? It's
reproducible ?

https://files.kde.org/digikam/

Note: bundle is now based on Qt 5.15.11 and KDE framework 5.110.

Thanks in advance

Gilles Caulier
Comment 5 sashok.olen 2024-07-03 02:07:30 UTC
According to my testing, this issue is still valid in Digikam 8.3.0.
As the report states, entering 3:4 as aspect ratio just returns all portrait aspect ratio images like 2:3 or 4:5, which is wrong and misleading.
Comment 6 sashok.olen 2024-07-03 02:10:06 UTC
I've checked and it applies to the AppImage version too.
Comment 7 Maik Qualmann 2024-07-04 19:22:28 UTC
Git commit 06783c22ed4e04e2acb9ddd9d6d7b7200ee19c32 by Maik Qualmann.
Committed on 04/07/2024 at 19:21.
Pushed by mqualmann into branch 'master'.

fix text filter for aspect ratio
FIXED-IN: 8.4.0

M  +1    -1    NEWS
M  +10   -5    core/libs/database/models/itemfiltersettings.cpp

https://invent.kde.org/graphics/digikam/-/commit/06783c22ed4e04e2acb9ddd9d6d7b7200ee19c32
Comment 8 sashok.olen 2024-07-11 09:22:40 UTC
I've tried the 8.4.0-20240710T162150 nightly (which I assume should contain the fix mentioned in the message above?) and the issue persists.
Comment 9 Maik Qualmann 2024-07-11 09:35:23 UTC
I can't imagine that the problem still exists. It works perfectly here now. But remember that you only select aspect ratio in the drop-down list, otherwise the corresponding text entries will also be searched for.
Otherwise, upload sample images with which the problem can be reproduced.

Maik