Bug 382570 - Right-click to menu item in global menu not forwarded
Summary: Right-click to menu item in global menu not forwarded
Status: CONFIRMED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Menu (show other bugs)
Version: 5.20.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-21 15:20 UTC by svadkost
Modified: 2020-12-01 04:57 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Delete bookmark on right click (21.82 KB, image/png)
2017-07-23 18:29 UTC, Luigi Toscano
Details
bookmarks (21.22 KB, image/png)
2017-07-23 23:34 UTC, svadkost
Details

Note You need to log in before you can comment on or make changes to this bug.
Description svadkost 2017-07-21 15:20:35 UTC
The only way to delete bookmarks is to edit config file.
Comment 1 Burkhard Lück 2017-07-22 09:21:06 UTC
In KHelpcenter 5.7.1 / Frameworks 5.34.0 / Qt 5.6.1 / Kubuntu 16.10 and master build from sources and neon fit unstable I can delete bookmark entries selecting "Delete Bookmark" in the context menu (right mouse button click) of an entry.
Doesn't this works for you as well?
Comment 2 Burkhard Lück 2017-07-22 09:24:07 UTC
Deleting Bookmarks is documented in the Help for KHelpcenter, see
https://docs.kde.org/stable5/en/applications/khelpcenter/interface-basics.html#menu-and-toolbar-ref
Comment 3 svadkost 2017-07-22 18:21:59 UTC
Where exactly i should right click? 
I can add and see bookmarks only in menubar. Toolbar button do nothing. 

Also i was hoping for approach like in the okular, in which if a file already have been bookmarked, then "Add Bookmark" menu option is replaced by "Remove Bookmark".
Comment 4 svadkost 2017-07-22 18:22:06 UTC
Where exactly i should right click? 
I can add and see bookmarks only in menubar. Toolbar button do nothing. 

Also i was hoping for approach like in the okular, in which if a file already have been bookmarked, then "Add Bookmark" menu option is replaced by "Remove Bookmark".
Comment 5 Luigi Toscano 2017-07-23 08:24:32 UTC
(In reply to svadkost from comment #4)
> Where exactly i should right click? 
> I can add and see bookmarks only in menubar. Toolbar button do nothing. 

If you right-click on the bookmark, the context menu shows the option to delete the bookmark.
Comment 6 svadkost 2017-07-23 17:17:03 UTC
(In reply to Luigi Toscano from comment #5)
> (In reply to svadkost from comment #4)
> > Where exactly i should right click? 
> > I can add and see bookmarks only in menubar. Toolbar button do nothing. 
> 
> If you right-click on the bookmark, the context menu shows the option to
> delete the bookmark.

Like i said, i can see bookmarks only through menubar, and there is no way to right-click in menubar.
Comment 7 Luigi Toscano 2017-07-23 18:29:24 UTC
Created attachment 106805 [details]
Delete bookmark on right click

(In reply to svadkost from comment #6)
> (In reply to Luigi Toscano from comment #5)
> > (In reply to svadkost from comment #4)
> > > Where exactly i should right click? 
> > > I can add and see bookmarks only in menubar. Toolbar button do nothing. 
> > 
> > If you right-click on the bookmark, the context menu shows the option to
> > delete the bookmark.
> 
> Like i said, i can see bookmarks only through menubar, and there is no way
> to right-click in menubar.

Right click *on the bookmark*.
Comment 8 Jack 2017-07-23 18:36:43 UTC
Perhaps capturing a screenshot would help explain what you are seeing.
Comment 9 svadkost 2017-07-23 23:34:19 UTC
Created attachment 106814 [details]
bookmarks
Comment 10 svadkost 2017-07-23 23:34:35 UTC
Alright, here we go(In reply to Luigi Toscano from comment #7)
> Created attachment 106805 [details]
> Delete bookmark on right click
> 
> (In reply to svadkost from comment #6)
> > (In reply to Luigi Toscano from comment #5)
> > > (In reply to svadkost from comment #4)
> > > > Where exactly i should right click? 
> > > > I can add and see bookmarks only in menubar. Toolbar button do nothing. 
> > > 
> > > If you right-click on the bookmark, the context menu shows the option to
> > > delete the bookmark.
> > 
> > Like i said, i can see bookmarks only through menubar, and there is no way
> > to right-click in menubar.
> 
> Right click *on the bookmark*.

Alright, it doesn't work with global menu then. And for some reason "Bookmarks" on the toolbar doesn't work either.
Comment 11 Luigi Toscano 2017-07-23 23:44:32 UTC
If the right click does not work, then there is a bug in the global menu.
Comment 12 Jack 2017-07-24 00:04:31 UTC
Luigi - I added Bookmarks to my toolbar, and even though I have added three bookmarks, and can see them in the Bookmarks menu, clicking Bookmarks on the toolbar does nothing at all - no pop-up list, so there might be a bug there.

svadkost: I'm also on 5.7.2, and I just created a bookmark, and if I right click, I get a context menu, and "Delete Bookmark" is the last item, and it works.

Your screenshot shows you clicked on the Bookmarks Menu, and the menu has "Add bookmark," "New Bookmarks Folder...," and one actual bookmark for "KDE Fundamentals."  What happens when you left click on "KDE Fundamentals" and what happens when you right click on it?  It looks like you are already on that page, so go somewhere else first, to see if clicking on the bookmark takes you to that entry.  It works correctly for me.
Comment 13 Luigi Toscano 2017-07-24 07:04:55 UTC
Let's summarize a bit, because I see a bit of confusion:
a) no one mentioned to click on the toolbar. Going back to the first answer from Burkhard, in order to remove a bookmark you should right click on the bookmark in the menu. This is what my screenshot in #c7 shows.
b) if the right click on the bookmark entry when the menu is shown in the global menu does not work, it's a bug of the global menu
c) there is maybe the open question of how to add another way to remove them, maybe, but first I'd like to have a) confirmed also by the reporter of the bug by disabling the global menu, and b) from the global menu maintainers (I can't test it right now)
Comment 14 Burkhard Lück 2017-07-24 07:32:21 UTC
I checked this issue in an up-to-date neon devedition unstable system:

* with Menubar style "In application" I get a context menu with an action "Delete Bookmark"

* with Menubar style "Title bar button" or "Application Menu widget" a right mouse button click on a bookmark entry does not open a context menu
Comment 15 Albert Astals Cid 2017-07-24 08:41:32 UTC
Yes, "global" menu probably doesn't have a way to communicate extra stuff like right mouse click. I guess it makes sense to add Kai Uwe for some input if this is even fixable at all when using the global menu.
Comment 16 svadkost 2017-07-24 17:03:02 UTC
(In reply to Luigi Toscano from comment #13)

Yes, with menu style "in application" i can delete bookmarks.

As for toolbar button, i just found that button, which clearly says "Bookmarks", but nothing happened when i clicked on it, so if it's not used maybe it would be better to delete it entirely?
Comment 17 Luigi Toscano 2017-07-24 17:50:04 UTC
(In reply to svadkost from comment #16)
> As for toolbar button, i just found that button, which clearly says
> "Bookmarks", but nothing happened when i clicked on it, so if it's not used
> maybe it would be better to delete it entirely?

If you keep the left click button pushed, it opens the Bookmarks menu.
Comment 18 Jack 2017-07-24 20:36:33 UTC
(In reply to Luigi Toscano from comment #17)
> If you keep the left click button pushed, it opens the Bookmarks menu.

I find that odd, but it does work.  Clicking a menu item brings up it's menu almost immediately.  There is a notable delay (although still under a second) pushing on the toolbar button before the menu comes up.  Am I wrong to assume a simple click should work instead of needing an extended press?
Comment 19 svadkost 2017-07-24 20:49:31 UTC
(In reply to Luigi Toscano from comment #17)
> If you keep the left click button pushed, it opens the Bookmarks menu.

Well, that's pretty strange way to do so. Maybe make it more straightforward? 

And add something like in the okular - when you jump to a bookmark "add bookmark" is replaced by "remove bookmark", because there's no need to add more than one bookmark isn't there?

Also, i just found out that there's no way to delete bookmark folders, or i just don't see how.
Comment 20 Luigi Toscano 2017-07-24 22:11:02 UTC
(In reply to Jack from comment #18)
> (In reply to Luigi Toscano from comment #17)
> > If you keep the left click button pushed, it opens the Bookmarks menu.
> 
> I find that odd, but it does work.  Clicking a menu item brings up it's menu
> almost immediately.  There is a notable delay (although still under a
> second) pushing on the toolbar button before the menu comes up.  Am I wrong
> to assume a simple click should work instead of needing an extended press?

From what I know, it it expected. You should see a small icon with an arrow pointing down in one of the corners. Anyway, not a KHelpCenter issue.

(In reply to svadkost from comment #19)
> (In reply to Luigi Toscano from comment #17)
> > If you keep the left click button pushed, it opens the Bookmarks menu.
> 
> Well, that's pretty strange way to do so. Maybe make it more
> straightforward? 

Same answer as before: that does not depend on KHelpCenter. If you use the Oxygen theme for the widget, it is more clear that the widget is a button that must be pushed. 

> And add something like in the okular - when you jump to a bookmark "add
> bookmark" is replaced by "remove bookmark", because there's no need to add
> more than one bookmark isn't there?
Maybe not straightforward, but...

> Also, i just found out that there's no way to delete bookmark folders, or i
> just don't see how.
... maybe enabling the link which opens KEditBookmarks should be enough.
Comment 21 svadkost 2017-07-25 12:37:54 UTC
(In reply to Luigi Toscano from comment #20)

> From what I know, it it expected. You should see a small icon with an arrow
> pointing down in one of the corners. Anyway, not a KHelpCenter issue.

How should i know the meaning of this arrow? I've never met buttons which require a long press. Anyway it's a bad design.

> (In reply to svadkost from comment #19)
> > (In reply to Luigi Toscano from comment #17)
> > > If you keep the left click button pushed, it opens the Bookmarks menu.
> > 
> > Well, that's pretty strange way to do so. Maybe make it more
> > straightforward? 
> 
> Same answer as before: that does not depend on KHelpCenter. If you use the
> Oxygen theme for the widget, it is more clear that the widget is a button
> that must be pushed. 

I don't remember such buttons in kde 4 either, but i only used it for a little while. 

> > And add something like in the okular - when you jump to a bookmark "add
> > bookmark" is replaced by "remove bookmark", because there's no need to add
> > more than one bookmark isn't there?
> Maybe not straightforward, but...
> 
> > Also, i just found out that there's no way to delete bookmark folders, or i
> > just don't see how.
> ... maybe enabling the link which opens KEditBookmarks should be enough.

Yes, maybe it would be better.
Comment 22 Kai Uwe Broulik 2017-07-25 14:12:36 UTC
Re-assigning to global menu.

This needs an extension to global menu, ie.)

1.) Fork QDBusMenuAdaptor (we already have a copy of QDBusMenuBar in plasma-integration to add some stuff we need) to support a (proprietary) "right-click" event (currently there is "hovered" and "clicked")
2.) Adjust our DBusMenuImporter in plasma-workspace to send that event
3.) Figure out a way to match the menu the application created to the menu global menu kded creates (breaks on Wayland even more)
Comment 23 Luigi Toscano 2017-07-30 12:58:11 UTC
Git commit d7208124aa4bb0386d2d500ee0f41cd1874a16ef by Luigi Toscano.
Committed on 30/07/2017 at 12:57.
Pushed by ltoscano into branch 'master'.

Enable the "Edit bookmarks" menu

Use the default values exposed by KBookmarks: both 'add' end 'edit'
actions exposed through the menus.
KEditBookmarks based on Frameworks 5 has been available for a while.

Copying also the original bug, which was (correctly) reassigned
to the global menu (the bug prevents the right click action from
working).

M  +0    -10   bookmarkowner.cpp
M  +0    -1    bookmarkowner.h

https://commits.kde.org/khelpcenter/d7208124aa4bb0386d2d500ee0f41cd1874a16ef
Comment 24 Alexander Mentyu 2018-01-29 13:15:52 UTC
Currently i can't right click on any app or panel global menu item - left clicking is always triggering

Plasma: 5.11.5
Apps: 17.12.1
Qt: 5.10.0
Frameworks: 5.42.0
Kernel: 4.14.14-1-MANJARO
Comment 25 Justin Zobel 2020-11-29 21:16:46 UTC
What application are you trying to delete bookmarks in?

I just tried to right-click on a bookmark in falkon but I get no context menu.
Comment 26 Albert Astals Cid 2020-11-30 18:07:38 UTC
(In reply to Justin Zobel from comment #25)
> What application are you trying to delete bookmarks in?
> 
> I just tried to right-click on a bookmark in falkon but I get no context
> menu.

Okular
Comment 27 Justin Zobel 2020-12-01 04:57:48 UTC
Can confirm this bug. Can right click on bookmarks in the menu of okular but in Global Menu I cannot.