Bug 382566 - Webengine does not support ad blocking
Summary: Webengine does not support ad blocking
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: webenginepart (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-21 13:25 UTC by avlas
Modified: 2021-08-23 12:34 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 21.08.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description avlas 2017-07-21 13:25:59 UTC
Enabling ad blocking in konqueror does nothing when using webengine
Also, one cannot visualize man and info pages in webengine
Both work in khtml, so I guess some porting is needed.

I use up-to-date KDE neon User Edition. Konqueror 4:17.04.3, kf5 5.36
Comment 1 Wolfgang Bauer 2018-02-07 13:03:41 UTC
The problem with man/info pages is tracked in bug#377084 already.
So let's keep this one for missing Adblock support.

Adblock is not working because the corresponding plugin is not ported to webengine yet. (well, actually it's not ported to Qt5/KF5 at all yet it seems, it is missing for KHTML and kwebkitpart too...)
Comment 2 avlas 2018-02-07 13:09:15 UTC
I am currently using kwebkitpart and adblock support is working just fine (same for man/info pages)
Comment 3 avlas 2018-02-07 14:41:38 UTC
(In reply to avlas from comment #2)
> I am currently using kwebkitpart and adblock support is working just fine
> (same for man/info pages)

Using kwebkitpart from here: https://cgit.kde.org/kwebkitpart.git
Comment 4 Wolfgang Bauer 2018-02-07 14:55:56 UTC
(In reply to avlas from comment #2)
> I am currently using kwebkitpart and adblock support is working just fine
Ok, fine.

It's just that I didn't see any adblock plugin installed on my system...
But also the KDE4 version only had one for KHTML, so that's probably something else.

> (same for man/info pages)
Sure, that works fine with KHTML and kwebkitpart...
Comment 5 avlas 2018-03-26 07:13:16 UTC
> But also the KDE4 version only had one for KHTML, so that's probably something else.

I think this was added to kwebkitpart from rekonq project.

I wish something similar could be ported now to webengine from falkon project.
Comment 6 Wolfgang Bauer 2018-03-31 22:30:20 UTC
(In reply to avlas from comment #5)
> > But also the KDE4 version only had one for KHTML, so that's probably something else.
> 
> I think this was added to kwebkitpart from rekonq project.

As I found out meanwhile, the konqueror plugin I was talking about is actually for listing blockable items on the current page (via an icon in the bottom right corner), and that one is not available for kwebkitpart either (and never was apparently), it's not even ported to KF5 for KHTML, i.e. it's missing completely in current versions.

So that's indeed something different, sorry.

Adblock support itself is indeed available in KHTML and kwebkitpart, but not webenginepart.
Comment 7 avlas 2018-04-03 14:33:32 UTC
I saw that the webengine-compatible adblocker is an extension in Falkon. It would be great if ported/integrated with KDE applications and Plasma ecosystem (thinking of Plasma web browser plasmoid and Konqueror, primarily; not sure if this would benefit Akregator too).
Comment 8 Wolfgang Bauer 2018-04-06 12:04:31 UTC
(In reply to avlas from comment #7)
> I saw that the webengine-compatible adblocker is an extension in Falkon. It
> would be great if ported/integrated with KDE applications and Plasma
> ecosystem (thinking of Plasma web browser plasmoid and Konqueror, primarily;
> not sure if this would benefit Akregator too).

Neither Plasma's web browser plasmoid not Akregator use Konqueror's webenginepart.

The plasmoid uses QtWebEngine directly.
Akregator (and kmail) use it via messagelib, which has an adblock plugin but that doesn't work currently (since the switch to QtWebEngine, although AFAICS some changes have been taken over from QupZilla, the predecessor of Falkon). That's unrelated to this bug report though.
Comment 9 avlas 2018-04-06 20:18:38 UTC
I see
Comment 10 Linux User #330250 2021-03-09 07:30:31 UTC
I can confirm that adblocking stopped working when switching from KHTML or WebKit to WebEngine. This is a bad situation, since KHTML is not basicly broken (most web pages don't work anymore), WebKit is gone (no longer even an option), and WebEngine being the only actively maintained rendering engine.

I'm sorry for being so late reporting it. I moved from WebKit to WebEngine a year ago (or so), and it's since then.

The request is, to have this a high priority to re-add support for it. Thanks.
Comment 11 Linux User #330250 2021-03-09 08:58:54 UTC
(In reply to Linux User #330250 from comment #10)
> since KHTML is not basicly broken (most web pages don't work anymore)
Comment 12 Linux User #330250 2021-03-09 09:00:03 UTC
should be: since KHTML is NOW basically broken... Sorry.
Comment 13 zeebra 2021-08-02 05:23:32 UTC
Since adblock is not working, perhaps it would be better to remove it and integrate optional ublock functionalities into Konqueror/webengine instead.

https://github.com/gorhill/uBlock
Comment 14 zeebra 2021-08-22 07:39:36 UTC
It is expected that uBlock Origin is compatible with any Chromium-based browsers.
Comment 15 Wolfgang Bauer 2021-08-23 12:34:22 UTC
Actually, adblock support was added to webenginepart meanwhile, see https://invent.kde.org/network/konqueror/-/commit/87bca4c4f3d4003e5ea506f715e1a8b7f43be9ee
This is included since 21.08.0, which was released two weeks ago.

I suppose this can be closed now then, please feel free to reopen (or open a new bugreport) if it still doesn't work with 21.08.0 or higher.