Bug 382537 - Remove embedding textures in brush presets
Summary: Remove embedding textures in brush presets
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (other bugs)
Version First Reported In: unspecified
Platform: Other Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-20 12:38 UTC by DoubleDee
Modified: 2017-07-27 13:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DoubleDee 2017-07-20 12:38:29 UTC
Currently, when a brush preset uses a pattern, whole pattern image is saved inside the kpp file. It creates two issues: brush presets use unnecessary higher disk space and kpp files over a certain filesize (somewhere around 6.5 MB) don't load when program starts (preset is not in the brush presets list) - it happens when a texture is big in size.
When pattern is missing from texture folder, brush preset informs about the missing resource anyway.

My suggestion is remove packing pattern into a kpp file completely.
Comment 1 Halla Rempt 2017-07-27 13:47:26 UTC
For this something else is needed as well: patterns used in brush presets should be saved to bundles, similar to how we save only the name of a brush tip, instead of the brush tip data.
Comment 2 Halla Rempt 2017-07-27 13:49:40 UTC
It will also need some careful management if we don't want to break older brush packs. Setting to wish.