Bug 382526 - Peruse 1.2 & master don't support ACBF metadata, and sometimes crash
Summary: Peruse 1.2 & master don't support ACBF metadata, and sometimes crash
Status: RESOLVED FIXED
Alias: None
Product: peruse
Classification: Applications
Component: general (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR crash
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-20 01:04 UTC by bk
Modified: 2018-09-24 12:51 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description bk 2017-07-20 01:04:57 UTC
Tested with both Peruse 1.2 and master, with and without baloo enabled.

For test files, I used:
- a CBZ created by hand, with a hand-written ACBF file;
- a CBZ created using perusecreator;
- and the two volumes of Pepper & Carrot that the Peruse commit log says were used as test cases for ACBF support.

In both versions, ACBF metadata does not appear to be used at all. I can see, in the terminal, a huge number of logging messages from AdvancedComicBookFormat, e.g.

```
bool AdvancedComicBookFormat::Sequence::fromXml(QXmlStreamReader*) Created sequence entry, which places this book as number 2 in the series "Pepper & Carrot"
bool AdvancedComicBookFormat::Author::fromXml(QXmlStreamReader*) Created author "David" "Revoy" "" responsible for "Writer" for language ""
bool AdvancedComicBookFormat::BookInfo::fromXml(QXmlStreamReader*) Created book information for the book with the titles ("Pepper & Carrot - Vol. 2", "Pepper & Carrot - Tome 2", "Pepper & Carrot - Zväzok č. 2")
```

but this isn't reflected in the UI; "group by author" does nothing, "group by series" groups by the directory the CBZ files are in, and "group by title" groups by the file name, the same as for non-ACBF books.

It is especially disheartening that Peruse can't even read ACBF files that it itself generates.

Peruse master, additionally, sometimes crashes when attempting to display the info panel for ACBF books. When it doesn't crash, it shows as up "publisher unknown, author unknown, no description", same as 1.2 and same as non-ACBF books.
Comment 1 Dan Leinir Turthra Jensen 2017-09-04 14:55:36 UTC
Looks like this report is for multiple issues. The main issue (not supporting acbf data for browsing) has been at least partly fixed in master, but the crashes are not related to that. If you could submit a new report for the crashes, with a backtrace showing the issue, i'd really appreciate it :) 

Fully fixing this will require reworking the model to support multiple authors, series and so on. This is entirely something i want to do, but it will take more work to get that done. Just wanted to tell you this isn't at all ignored.

Partial fix in https://commits.kde.org/peruse/2dffa45e9b49d8625d07a03c2a39b1cc0995149d
Comment 2 wolthera 2018-09-24 12:51:10 UTC
This one got fixed in https://phabricator.kde.org/R157:3794ea968ec6a39c10772c11b066f80c779e3ba8

The crashes are very likely the same one as these: https://bugs.kde.org/show_bug.cgi?id=398204

Because the cache isn't updated yet, it won't update when you change an acbf file, but those are covered by

https://bugs.kde.org/show_bug.cgi?id=398260
https://bugs.kde.org/show_bug.cgi?id=398211

So I'm going to close this bug :)