Bug 382506 - Impossible to save an ISO file to an empty folder on Gnome
Summary: Impossible to save an ISO file to an empty folder on Gnome
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: GUI/Usability (show other bugs)
Version: 17.04.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: k3b developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-19 15:58 UTC by Patrick Silva
Modified: 2018-09-20 22:00 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
file dialog without file name field, "open" button disabled (97.96 KB, image/png)
2017-07-19 15:59 UTC, Patrick Silva
Details
gnome save dialog (94.77 KB, image/png)
2017-07-20 03:17 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-07-19 15:58:26 UTC
create a new project, add some files, click "burn" button, check "only create image", select "image" tab, choose any empty folder to save your disc image file... oops, it's not possible do it because Gnome opens a file dialog that does not allow select an empty folder, its "open" button is disabled.
Another issue with this dialog is the lack of a field to write the ISO file name.
See my screenshot please.
Comment 1 Patrick Silva 2017-07-19 15:59:30 UTC
Created attachment 106732 [details]
file dialog without file name field, "open" button disabled
Comment 2 Leslie Zhai 2017-07-20 02:08:10 UTC
Hi Dr. Chapatin,

Yes, you need report the issue to Nautilus' developer to experience like this https://pbs.twimg.com/media/DFJMGcwUwAErqtI.png

Regards,
Leslie Zhai
Comment 3 Patrick Silva 2017-07-20 03:17:29 UTC
Created attachment 106745 [details]
gnome save dialog

k3b calls open dialog, Gnome has a save dialog like my screenshot shows.
Comment 4 Leslie Zhai 2017-07-20 03:23:16 UTC
(In reply to Dr. Chapatin from comment #3)
> Created attachment 106745 [details]
> gnome save dialog
> 
> k3b calls open dialog, Gnome has a save dialog like my screenshot shows.

but it is still Nautilus not Dolphin :)
Comment 5 Patrick Silva 2017-07-20 03:29:08 UTC
Sure. K3b calls incorrect nautilus dialog on Gnome.
K3b should call save dialog to save ISO file, not open dialog.
Comment 6 Leslie Zhai 2017-07-21 02:04:23 UTC
(In reply to Dr. Chapatin from comment #5)
> Sure. K3b calls incorrect nautilus dialog on Gnome.
> K3b should call save dialog to save ISO file, not open dialog.

I argue that KUrlRequester call open dialog is correct https://github.com/KDE/kio/blob/master/src/widgets/kurlrequester.cpp#L312
Comment 7 Patrick Silva 2017-07-21 02:12:31 UTC
if the user wants save an ISO to hard disk, how to do it on Gnome with an open dialog instead a save dialig? There is a problem, where is this problem? Gnome? Arch packing? K3b code? Gnome users need a solution to save ISOs to the HD using k3b.
Comment 8 Leslie Zhai 2017-07-21 02:40:01 UTC
(In reply to Dr. Chapatin from comment #7)
> if the user wants save an ISO to hard disk, how to do it on Gnome with an
> open dialog instead a save dialig? There is a problem, where is this
> problem? Gnome? Arch packing? K3b code? Gnome users need a solution to save
> ISOs to the HD using k3b.

Just use KDE and Dolphin :)

Sorry I can NOT change KIO::KUrlRequester https://github.com/KDE/kio/blob/master/src/widgets/kurlrequester.cpp#L326 about _k_slotOpenDialog, because KIO is so important core component, you can see how many packages Required By it https://www.archlinux.org/packages/extra/x86_64/kio/

And K3B is a KDE Application, it use KIO::KUrlRequester to SET temporary FilePath, it behaviors correctly for KDE and Dolphin, but I am not a GNOME developer only report bug to them https://bugzilla.gnome.org/show_bug.cgi?id=777077
Comment 9 Patrick Silva 2017-07-21 12:46:58 UTC
read the comments from a gnome dev please
https://bugzilla.gnome.org/show_bug.cgi?id=785228

reopening because this problem needs to be fixed...
Comment 10 ernestas 2017-07-21 13:44:58 UTC
https://api.kde.org/frameworks/kio/html/classKUrlRequester.html#ad3ad89008d0ea59335d7495084a57fe9

The default seems to be AcceptOpen.

Setting it to the correct value here https://github.com/KDE/k3b/blob/503b9d1583095408f41fc8e45540c19603a251ce/src/k3btempdirselectionwidget.cpp#L71 might do the trick.

I would build and test locally, but I’m not exactly familiar with the platform.
Comment 11 Leslie Zhai 2017-07-21 14:04:32 UTC
Hi Ernestas,

Thanks for your hint! I will try it.

Regards,
Leslie Zhai
Comment 12 Leslie Zhai 2017-07-24 02:44:32 UTC
Git commit 51e1c0bc5754026d607255cdf8f93df5fdfb35aa by Leslie Zhai.
Committed on 24/07/2017 at 02:42.
Pushed by lesliezhai into branch 'master'.

Fix impossible to save an ISO file to an empty folder on GNOME issue.

A patch by Ernestas Kulik!

M  +1    -0    src/k3btempdirselectionwidget.cpp

https://commits.kde.org/k3b/51e1c0bc5754026d607255cdf8f93df5fdfb35aa
Comment 13 Patrick Silva 2017-07-24 12:46:51 UTC
Thanks guys!
Comment 14 Patrick Silva 2017-08-19 13:46:41 UTC
k3b 17.08 has this same problem.
Comment 15 ernestas 2017-08-19 14:20:37 UTC
(In reply to Dr. Chapatin from comment #14)
> k3b 17.08 has this same problem.

If the release was made from the Applications/17.08 branch, then the commit is simply missing, judging by the log.
Comment 16 Patrick Silva 2017-08-19 14:23:22 UTC
(In reply to Ernestas Kulik from comment #15)
> (In reply to Dr. Chapatin from comment #14)
> > k3b 17.08 has this same problem.
> 
> If the release was made from the Applications/17.08 branch, then the commit
> is simply missing, judging by the log.

I dont know. My k3b is from Arch repositories.
Comment 17 Leslie Zhai 2017-08-21 01:50:29 UTC
Hi Dr. Chapatin,

Please try k3b-git https://aur.archlinux.org/packages/k3b-git

Regards,
Leslie Zhai
Comment 18 Patrick Silva 2017-08-21 02:05:07 UTC
it's outdated...
Last Updated:	2017-04-20 19:15
Comment 19 Leslie Zhai 2017-08-21 02:08:41 UTC
Dear Felix,

> it's outdated...
> Last Updated:	2017-04-20 19:15

Please help Dr. Chapatin to test k3b-git for ArchLinux, thanks a lot :)

Regards,
Leslie Zhai
Comment 20 Patrick Silva 2017-08-21 02:43:52 UTC
Why does 17.08 release not include this fix?
Comment 21 Leslie Zhai 2017-08-21 02:48:17 UTC
Dear Albert,

> Why does 17.08 release not include this fix?

Perhaps I missed some important Release Notification email? https://mail.kde.org/pipermail/release-team/2017-August/thread.html

Regards,
Leslie Zhai
Comment 22 ernestas 2017-08-21 04:55:31 UTC
(In reply to Dr. Chapatin from comment #18)
> it's outdated...
> Last Updated:	2017-04-20 19:15

git packages do not require constant updating, because they build from git sources.
Comment 23 Patrick Silva 2017-08-21 14:27:01 UTC
(In reply to Ernestas Kulik from comment #22)
> (In reply to Dr. Chapatin from comment #18)
> > it's outdated...
> > Last Updated:	2017-04-20 19:15
> 
> git packages do not require constant updating, because they build from git
> sources.
Thank you Ernestas.
But build fails
"-- Configuring incomplete, errors occurred!"
Comment 24 ernestas 2017-08-21 14:44:57 UTC
(In reply to Dr. Chapatin from comment #23)
> (In reply to Ernestas Kulik from comment #22)
> > (In reply to Dr. Chapatin from comment #18)
> > > it's outdated...
> > > Last Updated:	2017-04-20 19:15
> > 
> > git packages do not require constant updating, because they build from git
> > sources.
> Thank you Ernestas.
> But build fails
> "-- Configuring incomplete, errors occurred!"

That’s unfortunate, but let’s not go off-topic here by trying to fix the build (or the package).

I’ll set up the environment on my machine and see how it looks.
Comment 25 ernestas 2017-08-22 07:41:13 UTC
master behaves as expected with the fix (the file chooser has the GTK_FILE_CHOOSER_ACTION_SAVE action), but there seems to be another bug somewhere, preventing the file name to be set (gtk_file_chooser_set_current_name() is called before setting the action, maybe?).

In any case, this is definitely fixed.
Comment 26 Patrick Silva 2017-11-18 15:00:35 UTC
(In reply to Ernestas Kulik from comment #25)
> there seems to be another bug
> somewhere, preventing the file name to be set
> (gtk_file_chooser_set_current_name() is called before setting the action,
> maybe?).

I noticed k3b does not add .iso extension to the file name.
Is this the problem you are referring to?
Comment 27 Patrick Silva 2018-09-20 22:00:48 UTC
cannot reproduce on Arch Linux running Gnome 3.30 and K3b 18.08.1.