Bug 382505 - Buttons don't respond to kcm color palette changes
Summary: Buttons don't respond to kcm color palette changes
Status: RESOLVED FIXED
Alias: None
Product: frameworks-qqc2-desktop-style
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.39.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-19 14:40 UTC by Harald Sitter
Modified: 2021-01-26 21:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
screenshot (374.79 KB, image/png)
2017-07-19 14:40 UTC, Harald Sitter 		Details
On my system (105.78 KB, image/png)
2017-09-04 15:37 UTC, Aleix Pol 		Details
new screenshot (229.51 KB, image/png)
2017-09-05 12:36 UTC, Harald Sitter 		Details
without qqc2-desktop-style (160.55 KB, image/png)
2017-09-05 17:53 UTC, Aleix Pol 		Details
with qqc2-desktop-style (203.24 KB, image/png)
2017-09-05 17:55 UTC, Aleix Pol 		Details
screenshot after reboot with qqc2 style (242.61 KB, image/png)
2017-09-06 11:06 UTC, Harald Sitter 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2017-07-19 14:40:43 UTC 
Created attachment 106730 [details]
screenshot

On git master... when using breeze dark as color scheme. the colors of the section headers on the update page "application updates" and "system updates" (as well as the "no updates") labels use an incorrectly (i.e. poorly contrasted color).

see screenshot
Comment 1 Aleix Pol 2017-09-04 15:37:41 UTC 
Created attachment 107686 [details]
On my system

Maybe you have an old Kirigami?

We are using Kirigami.Heading there.
Comment 2 Harald Sitter 2017-09-05 12:36:22 UTC 
Created attachment 107700 [details]
new screenshot

This happens when qqc2-desktop-style isn't installed, which I've now fixed in neon.

The good news is that installing it seems to fix the header.
Now the buttons are broken though, see screenshot. That also seems to be a problem somewhere else though as I see systemsettings having the same problem. I am not even sure where to look to debug this -.-
Comment 3 Aleix Pol 2017-09-05 17:53:06 UTC 
Created attachment 107705 [details]
without qqc2-desktop-style

I confirm that the color problem presents itself when there's no qqc2-desktop-style.
Comment 4 Aleix Pol 2017-09-05 17:55:07 UTC 
Created attachment 107706 [details]
with qqc2-desktop-style

But I do get the proper colors on the button when it's installed
Comment 5 Marco Martin 2017-09-05 18:43:43 UTC 
yeah, the style needs to be installed, otherwise breakages are to be expected..
however the light buttons with the style installed were not expected, neither reproducible it seems :/

did you switch to breeze-dark on the fly and the app failed to fully update or discover started from the beginning with the wrongly rendered buttons?
Comment 6 Harald Sitter 2017-09-06 11:06:31 UTC 
Created attachment 107716 [details]
screenshot after reboot with qqc2 style

Nope that system is always breeze-dark. I've since rebooted and now the buttons work though. Either there's something fishy with style init or there was some obscure cache somewhere. Until otherwise indicated I am content in assuming it was a cache problem. Closing bug.
Comment 7 Aleix Pol 2017-09-06 11:11:32 UTC 
No, no. It's a valid issue. Only now we know it's in "qqc2-desktop-style".
Comment 8 Harald Sitter 2017-09-06 11:19:12 UTC 
I don't think this has necessarily to do with the palette though. Note how the actual button style in https://bugs.kde.org/attachment.cgi?id=107700 is not even breeze.
Comment 9 Nate Graham 2021-01-26 21:49:52 UTC 
This seems to be working now.