Bug 382435 - Incorrect English in message
Summary: Incorrect English in message
Status: RESOLVED INTENTIONAL
Alias: None
Product: valgrind
Classification: Developer tools
Component: memcheck (other bugs)
Version First Reported In: 3.11.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-17 17:53 UTC by Blake McBride
Modified: 2018-07-25 05:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blake McBride 2017-07-17 17:53:34 UTC
The message is logically wrong.

"All heap blocks were freed -- no leaks are possible"

should be:

"All heap blocks were freed -- no leaks were detected"
Comment 1 Philippe Waroquiers 2017-07-21 09:44:03 UTC
I am not sure to understand what is really wrong in this message,
but it is like that since at least 2009 and nobody complained up
to now about a difficulty to understand it.
As tests are depending on this output, and possibly some users have scripts
checking for this string, it looks better to not improve this message,
as the cost/benefit seems not that good
Comment 2 Julian Seward 2018-07-25 05:19:17 UTC
The message as it stands is really what I intended.  If all heap blocks
are freed then it isn't possible to have any leaks, since there are no
blocks to leak.  Hence the wording.