Bug 382418 - Krita froze during a save and Autosave didn't save the animation
Summary: Krita froze during a save and Autosave didn't save the animation
Status: RESOLVED WORKSFORME
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: macOS (DMG) Linux
: NOR major
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-17 01:20 UTC by Joey
Modified: 2021-06-16 11:50 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joey 2017-07-17 01:20:13 UTC
Krita sometimes freezes after saving a png.file after a krita file.I have lost an animation that took about ten hours to make and I have lost time and money over this incident.Please fix this problem.
Comment 1 grum999 2021-06-12 09:21:15 UTC
I reopen this bug, I'm not sure why it has been set to "RESOLVED/NOT A BUG"

Currently on Krita 5 (krita-5.0.0-prealpha-dba5ce5-x86_64.appimage), if autosave run while an animation is rendering, render is stopped with a popup message "failed to render animation frames”.


STEPS TO REPRODUCE
1) Create an animation for which time to render is long enough to have autosave triggered 
2) Ensure that document is in modified state (ie: the autosave will be triggered)
3) Render animation


OBSERVED RESULTS
Render is interrupted, there’s a status bar notification "autosaving postponed: document is busy" but rendering continues.
A couple of seconds after, there's a new notification.
This is repeated 4 times and then finally, autosave is applied.

A dialog box "waiting for image operation to complete (<updating>)" is displayed for a couple of seconds and it stops the rendering with a "failed to render animation frames" message.


EXPECTED RESULTS
If an animation is rendering:
- the autosave should properly be cancelled without stopping render
or
- the autosave should be temporary disabled before animation is rendered, and enabled once rendering is done (if enable before rendering)


NOTES
- Maybe related to https://bugs.kde.org/show_bug.cgi?id=410024
- Discussion on krita-artists: https://krita-artists.org/t/krita-5-animation-curves-applied-to-transform-mask/24895/13?u=grum999


Grum999
Comment 2 Tiar 2021-06-15 14:20:33 UTC
Setting to "major", because it leads to dataloss. I don't think it's related to a crash, maybe it was just taking a long time saving...
Comment 3 Eoin O'Neill 2021-06-16 02:15:08 UTC
Grumm and Tiar:

The bug that Grumm is describing is not the same as Joey posted. Have you verified that this is actually a bug in the current version of Krita?

And Grumm, please be careful with reopening bugs. Joey is discussing the saving of a KRA file, not about rendering an animation...
Comment 4 Eoin O'Neill 2021-06-16 03:04:58 UTC
I'm closing this bug because I've tested and haven't been able to reproduce either Joey or Grum's issue.

1) Auto saves do not seem to interrupt animation rendering or cause a failure. I've tested with a animation that took ~2 minutes to render with a 1 minute autosave frequency. Autosaves seem to properly halt until animation rendering process completes.

2) Joey's issue regarding saving a png (export > png) file immediately after a kra file does not seem to occur on my system -- though perhaps could happen on lower spec systems? I can't verify that krita won't freeze on all machines though.


Joey, regarding your issue, please try some of the newest versions of krita and report back if you're having any issues with saving KRA files when immediately saving a png file. If you do, please provide system specifications and operating system details if possible.

grum999@grum.fr , regarding your issue, could you please test the latest nightly build and, if your issue persists, file a separate bug report and provide specifics on:

- How many frames Krita is trying to render (viewable on the render progress bar as [currentFrame]/[totalFrameCount].)
- How many cores your system has dedicated to rendering animations or caching frame data (should be viewable on the performance tab.)
- Does the failure occur when saving image sequences or does it occur during the FFMPEG phase (You can verify by checking if all image frames have rendered out properly and saved to that hard disk.)

Thanks for taking the time to file bugs for Krita,
Eoin.
Comment 5 grum999 2021-06-16 11:50:26 UTC
"""
The bug that Grumm is describing is not the same as Joey posted. Have you verified that this is actually a bug in the current version of Krita?

And Grumm, please be careful with reopening bugs. Joey is discussing the saving of a KRA file, not about rendering an animation...
"""

For what I understood, Joey spent 10hours to make an *animation*.
And I'm practically sure that by "during a png save" it was "rendering animation as png sequence"

And even if I'm not the best placed about how Krita is internally working, I now that at 60% saving, krita starts to save layers. 
So, it could be very long to save an animation if there's hundred or thousand of keyframes (I have some animation with more than 5000 keyframes...)

And people can consider that it's frozen, especially on slow computers, and kill process.
(already saw it on KA)

But ok, I won't fight about how to interpret this bug for which initial description was too vague.



I'll try to create a new bug because I confirm what I wrote; I spent time to test and describe precisely what happen, in which condition.
It's confirmed by AhabGreybeard on KA, for which symptoms are *exactly the same* than me.

And if I deactivate autosave, everything is fine.

So testing with the last app image krita-5.0.0-prealpha-e433799-x86_64.appimage, the problem is still here.




"""How many frames Krita is trying to render (viewable on the render progress bar as [currentFrame]/[totalFrameCount].)"""
This part have no importance... 
It occurs with 2 keyframes on my side as well as hundred of keyframes.
Total number is around 600frames on my test but it means nothing as from a imple animation of 600 frames it could 15s to render all frame to more than one hour for a more complex 600frames animation.


"""How many cores your system has dedicated to rendering animations or caching frame data (should be viewable on the performance tab.)"""
from 1 core to 24 Cores, the problem occurs.


"""Does the failure occur when saving image sequences or does it occur during the FFMPEG phase (You can verify by checking if all image frames have rendered out properly and saved to that hard disk.)"""
Rendered as PNG sequence, then no ffmpeg in process



Grum999