Bug 382353 - Gnome: app icon missing from dash (left bar) and alt+tab menu
Summary: Gnome: app icon missing from dash (left bar) and alt+tab menu
Status: RESOLVED FIXED
Alias: None
Product: kolourpaint
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: kolourpaint-support
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-14 21:03 UTC by Patrick Silva
Modified: 2017-07-15 19:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
alt+tab menu (84.84 KB, image/png)
2017-07-14 21:03 UTC, Patrick Silva
Details
dash (156.16 KB, image/png)
2017-07-14 21:04 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-07-14 21:03:38 UTC
Created attachment 106633 [details]
alt+tab menu

See the screenshots please,

kolourpaint 17.04.3 on Arch
Comment 1 Patrick Silva 2017-07-14 21:04:10 UTC
Created attachment 106634 [details]
dash
Comment 2 Martin Koller 2017-07-15 07:27:03 UTC
This seems to be a packaging/installation problem in Arch.
kolourpaint delivers application icons in the source tree:
./pics/app/16-apps-kolourpaint.png
./pics/app/32-apps-kolourpaint.png
./pics/app/22-apps-kolourpaint.png
./pics/app/48-apps-kolourpaint.png

Please get in contact with people from Arch and discuss there what they think is missing.
Comment 3 Antonio Rojas 2017-07-15 13:11:47 UTC
The icons are correctly installed

> ls -l /usr/share/icons/hicolor/*/apps/kolourpaint.*
/usr/share/icons/hicolor/16x16/apps/kolourpaint.png
/usr/share/icons/hicolor/22x22/apps/kolourpaint.png
/usr/share/icons/hicolor/32x32/apps/kolourpaint.png
/usr/share/icons/hicolor/48x48/apps/kolourpaint.png
/usr/share/icons/hicolor/scalable/apps/kolourpaint.svgz
Comment 4 Christoph Feck 2017-07-15 13:17:43 UTC
Martin, the reporter runs Wayland. Please check https://community.kde.org/Wayland/Porting_Notes
Comment 5 Martin Koller 2017-07-15 13:33:14 UTC
I don't see what is missing here.
kolourpaint uses the org.kde.kolourpaint.desktop file
and it uses KAboutData and also does
  aboutData.setDesktopFileName(QStringLiteral("org.kde.kolourpaint"));
Comment 6 Christoph Feck 2017-07-15 13:59:26 UTC
I checked the xprop output. Kolourpaint does not set a window icon. KWin falls back to use the icon from the desktop file, but the Gnome window manager does not.
Comment 7 Martin Koller 2017-07-15 19:31:01 UTC
Git commit 3b4d0511d5284efc9d7caed79a363c240ad580ed by Martin Koller.
Committed on 15/07/2017 at 19:30.
Pushed by mkoller into branch 'Applications/17.04'.

explicitely set window icon

M  +1    -0    kolourpaint.cpp

https://commits.kde.org/kolourpaint/3b4d0511d5284efc9d7caed79a363c240ad580ed
Comment 8 Luigi Toscano 2017-07-15 19:33:36 UTC
Two notes:
- the fix will go into 17.08 (17.04.3 is already tagged)
- is there a special reason why the default assignee is a mailing list on sourceforge?
Comment 9 Martin Koller 2017-07-15 19:35:27 UTC
Git commit ea7e98611c2bd619a5359152142ddc6abb0dd527 by Martin Koller.
Committed on 15/07/2017 at 19:32.
Pushed by mkoller into branch 'master'.

explicitely set window icon

M  +1    -0    kolourpaint.cpp

https://commits.kde.org/kolourpaint/ea7e98611c2bd619a5359152142ddc6abb0dd527
Comment 10 Martin Koller 2017-07-15 19:38:20 UTC
(In reply to Luigi Toscano from comment #8)
> Two notes:
> - the fix will go into 17.08 (17.04.3 is already tagged)

sorry, was a mistake. pushed already to master

> - is there a special reason why the default assignee is a mailing list on
> sourceforge?

since it's like that for ages ?
I just took over maintainership - the rest is like before and the mailing list is still used.
Comment 11 Luigi Toscano 2017-07-15 19:39:40 UTC
(In reply to Martin Koller from comment #10)
> (In reply to Luigi Toscano from comment #8)
> > Two notes:
> > - the fix will go into 17.08 (17.04.3 is already tagged)
> 
> sorry, was a mistake. pushed already to master

Ups, I already merged 17.04 into master (I'm trying to branch 17.08).

> 
> > - is there a special reason why the default assignee is a mailing list on
> > sourceforge?
> 
> since it's like that for ages ?
> I just took over maintainership - the rest is like before and the mailing
> list is still used.

I wonder if we can move it to kde.org then...