Bug 382324 - Translucent lines at some places after update to 5.36 frameworks
Summary: Translucent lines at some places after update to 5.36 frameworks
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.10.4
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-14 06:21 UTC by tzt
Modified: 2018-06-06 17:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
cal (26.84 KB, image/png)
2017-07-14 06:21 UTC, tzt
Details
share (23.14 KB, image/png)
2017-07-14 06:22 UTC, tzt
Details
wingroup (11.91 KB, image/png)
2017-07-14 06:22 UTC, tzt
Details
newaccount (61.58 KB, image/png)
2017-09-08 04:08 UTC, tzt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tzt 2017-07-14 06:21:29 UTC
Created attachment 106605 [details]
cal

It's default Breeze Dark theme.
Comment 1 tzt 2017-07-14 06:22:06 UTC
Created attachment 106606 [details]
share
Comment 2 tzt 2017-07-14 06:22:32 UTC
Created attachment 106607 [details]
wingroup
Comment 3 tzt 2017-07-25 17:01:52 UTC
I moved it to plasma-panel due to no one answered for 10 days.
Comment 4 Kai Uwe Broulik 2017-07-25 20:35:45 UTC
Looks like the SVG cache got corrupted, does removing the plasma* files from ~/.cache fix this?
Comment 5 tzt 2017-07-25 21:04:38 UTC
(In reply to Kai Uwe Broulik from comment #4)
> Looks like the SVG cache got corrupted, does removing the plasma* files from
> ~/.cache fix this?

No, it's still the same after deleting these files and logout-login.
Comment 6 tzt 2017-07-26 06:06:20 UTC
Also I had the same problem with tray applets (volume, clipboard, network etc) since update to 5.33-34 but in 5.35 it was fixed somehow. And now, in 5.36 it's returned but in other places.
Comment 7 tzt 2017-08-15 06:36:06 UTC
Just updated to 5.37 frameworks and lines are still there. So why there's no confirmation for the bug? You think it isn't bug or what?
Comment 8 Christoph Feck 2017-09-08 00:58:23 UTC
It is a bug, but nobody else seems to have it. Can you reproduce with a freshly created user account?
Comment 9 tzt 2017-09-08 04:08:06 UTC
Created attachment 107742 [details]
newaccount
Comment 10 tzt 2017-09-08 04:25:20 UTC
(In reply to Christoph Feck from comment #8)
> It is a bug, but nobody else seems to have it. Can you reproduce with a
> freshly created user account?

Yes, it's still presented with the new account (see attachment from my previous post), it's presented even when I boot from livecd with nouveau driver (or what it comes with by default). Usually I use nvidia driver. But I got another machine with intel integrated graphics and this bug represented there exactly the same way. Something happens with frameworks from time to time that makes it appear or disapper, but I don't know what.
I played out with settings and found that it disappear when I choose XRender as the rendering backend, but it's not a solution.
Comment 11 Vlad Zahorodnii 2018-05-30 13:48:30 UTC
Marco, is it okay if I take this bug?
Comment 12 Vlad Zahorodnii 2018-05-30 15:06:42 UTC
https://phabricator.kde.org/D13215
Comment 13 Vlad Zahorodnii 2018-06-06 17:52:12 UTC
Git commit dce258bee3da854980b6f2430b26f7025752a505 by Vlad Zagorodniy.
Committed on 06/06/2018 at 17:52.
Pushed by vladz into branch 'master'.

FrameSvg: Recache maskFrame if enabledBorders has been changed

Summary:
In some cases, when rendering frame svg background, measures & margins
do not correspond to `enabledBorders`. I.e. `bottomHeight` may be equal to 5,
but the bottom border is disabled. This causes visual artifacts like this

{F5878318, layout=center, size=full}

//Pay close attention to the bottom of the Task switcher. It has a transparent strip at the bottom, which shouldn't be there.//

The cause of this problem is that FrameSVGPrivate::alphaMask doesn't take enabledBorders
into account when it's making decision whether it should update maskFrame.

Just for reference, this is "after"

{F5878319, layout=center, size=full}
Related: bug 390632, bug 391659

Test Plan:
* Triggered the Breeze task switcher (with compositing on and off)
* Didn't see any transparent strips

---

* Tried running FrameSvgTest, still passes

Reviewers: #plasma, #frameworks, mart

Reviewed By: #plasma, mart

Subscribers: abetts, mart, aseigo, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D13215

M  +16   -10   src/plasma/framesvg.cpp

https://commits.kde.org/plasma-framework/dce258bee3da854980b6f2430b26f7025752a505