Bug 382282 - Name changes of the "else" alternative on combined fragment is not saved
Summary: Name changes of the "else" alternative on combined fragment is not saved
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 2.22.3 (KDE Applications 17.04.3)
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2017-07-12 17:00 UTC by Ralf Habacker
Modified: 2017-08-06 22:00 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/umbrello/7f327bfaba35ec6960ecc8677f37b705113f43a2
Version Fixed In: 2.23.0 (KDE Applications 17.08.0)

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2017-07-12 17:00:02 UTC 
How to reproduce ?
1. start umbrello
2. add a sequence diagram
3. select "combined fragment" from the toolbox
4. Choose "Alternative"
5. press okay and enter something as text for the first alternative, then press okay again
6. Double click on the "else text of the combined fragment
7. Change the text in the first edit widget after the "floating dashline" label from 'else' to 'else12345'.
8 press okay

What happens ?
The text of the second alternative has not been changed; it still shows 'else'.

What is expected ?
The text of the second alternative should be 'else12345'.
Comment 1 Ralf Habacker 2017-07-12 17:27:23 UTC 
This bug has nearly the same reason as bug 382279 e.g. an additonal if (m_pInstanceWidget->isFloatingDashLineWidget()) ... should fix this.
Comment 2 Sujith Shivaprakash 2017-07-15 21:05:30 UTC 
(In reply to Ralf Habacker from comment #1)
> This bug has nearly the same reason as bug 382279 e.g. an additonal if
> (m_pInstanceWidget->isFloatingDashLineWidget()) ... should fix this.

Hello Ralf,

Where do I get access to the source code and how should I proceed about making changes, I am currently using a windows machine ? 


Thanks
Sujith
Comment 3 Ralf Habacker 2017-07-16 18:30:58 UTC 
(In reply to Sujith Shivaprakash from comment #2)
> Where do I get access to the source code 
https://cgit.kde.org/umbrello.git/
> and how should I proceed about making changes, I am currently using a windows machine ? 
If you want to hack on umbrello using a windows development machine you should take a look at https://community.kde.org/Craft
Comment 4 Ralf Habacker 2017-08-06 22:00:50 UTC 
Git commit 7f327bfaba35ec6960ecc8677f37b705113f43a2 by Ralf Habacker, on behalf of Alessandro Stranieri.
Committed on 06/08/2017 at 22:00.
Pushed by habacker into branch 'Applications/17.08'.

Fix renaming of combined fragment sections' names

The text displayed in the first and second section of a combined fragment
widget are stored in the text variable, which was not set by the
ClassGeneralPage::apply method. This commit fixes this method's logic.

Differential Revision: https://phabricator.kde.org/D6846
FIXED-IN:2.23.0 (KDE Applications 17.08.0)
Related: bug 382279

M  +15   -0    umbrello/dialogs/pages/classgeneralpage.cpp
M  +1    -0    umbrello/dialogs/pages/classgeneralpage.h

https://commits.kde.org/umbrello/7f327bfaba35ec6960ecc8677f37b705113f43a2