Bug 382217 - Use normalized connects [patch]
Summary: Use normalized connects [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Runtime (show other bugs)
Version: 5.6.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-10 20:15 UTC by Simon
Modified: 2018-08-20 21:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments
Normalize all signals and slots (35.17 KB, patch)
2017-07-10 20:15 UTC, Simon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon 2017-07-10 20:15:59 UTC
Created attachment 106545 [details]
Normalize all signals and slots

When signals/slots are parsed they are "normalized" if necessary. It is thus a slight performance improvement to use the "normal" format. See:
http://doc.qt.io/qt-4.8/signalsandslots.html#advanced-signals-and-slots-usage
https://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures/

The patch was created by running the official normalization utility on all *cpp files:
https://github.com/qt/qtrepotools/tree/master/util/normalize
Comment 1 caulier.gilles 2018-08-20 21:50:59 UTC
Simon,

I not using your patch, but is review all Krazy static analyzer reports where signal/slot normalization is not respected, and i fixed all (mostly more than 300 reports since 3 months - not only slots normalization).

http://ebn.kde.org/krazy/reports/extragear/graphics/digikam/

I close this file now.

Gilles Caulier