Bug 382185 - resources color is only used for border
Summary: resources color is only used for border
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: monthview (show other bugs)
Version: 5.9.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-10 07:27 UTC by Martin Koller
Modified: 2018-10-11 21:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.9.3


Attachments
agenda view (40.72 KB, image/png)
2017-07-10 14:59 UTC, Martin Koller
Details
month view (18.99 KB, image/png)
2017-07-10 14:59 UTC, Martin Koller
Details
colors config (114.04 KB, image/png)
2017-07-10 16:44 UTC, Martin Koller
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Koller 2017-07-10 07:27:10 UTC
In month view the color I assigned for a resource is only used to draw a thin - close to invisible - border. The main color is all the same.

The color per event should be the same as in the agenda view.
Comment 1 Laurent Montel 2017-07-10 10:10:28 UTC
could you provide a screenshot as here it's correct.
Comment 2 Martin Koller 2017-07-10 14:59:23 UTC
Created attachment 106533 [details]
agenda view
Comment 3 Martin Koller 2017-07-10 14:59:44 UTC
Created attachment 106534 [details]
month view
Comment 4 Martin Koller 2017-07-10 15:00:37 UTC
the attached screenshots show the same week in both mentioned views
Comment 5 Laurent Montel 2017-07-10 16:09:36 UTC
Ok
could you make a screenshot of config->color &font-> color

Perhaps it's a problem with to-do due today color  or others.
thanks
Comment 6 Martin Koller 2017-07-10 16:44:17 UTC
Created attachment 106537 [details]
colors config
Comment 7 Denis Kurz 2018-10-09 15:12:14 UTC
This is still a settings problem:

KOrg preferences -> Views -> Month Views. There's a radio group at the bottom of that tab where you can select to use category colors only.

I assume you use the category color for the border and the resource color for the fill.

If I'm right, we can close here, but I'm a little confused by the new variety of resolutions. I guess it's "NOT A BUG"?
Comment 8 Martin Koller 2018-10-09 16:22:54 UTC
Agenda View and Month View settings both show
* Category inside, calendar outside

It seems that the month view has a different behavior than the agenda view
when there is no category specified for an event.
It seems agenda view uses the calendar color inside when no category is defined, but month view uses a default color in this case.
Comment 9 Denis Kurz 2018-10-09 20:23:40 UTC
I submitted a patch that makes it more consistent:

https://phabricator.kde.org/D16088

In particular, the color for items with no category is only used in Category-Only color settings with this patch. This is exactly what the Settings dialog of KOrganizer states (in "Preferences -> Colors and Fonts -> Colors -> Categories"). Agenda View already had it right; the patch fixes Month View.

You might argue that this is not what the user probably wants: I would expect to identify items with no category in any setting that usually displays the category in any way. However, I think it is most sensible to first fix the current, inconsistent behavior, and ask for other behavior in a separate feature request. Feel free to disagree.
Comment 10 Denis Kurz 2018-10-11 21:22:38 UTC
Git commit 0b12580c8e848089a373dadae1c3e12b3ea0a531 by Denis Kurz.
Committed on 11/10/2018 at 21:22.
Pushed by dkurz into branch 'Applications/18.08'.

Fix color inconsistency for unset categories.

Summary:
KOrganizer's preference dialog states that the color for unset
categories is only used on the categories-color-only setting. However,
this is currently not true for Month View, where in each of the mixed
settings (category-border, resource-fill, or vice versa) the
unset-category color is also used. With this patch, Month View considers
the unset-category color only in the category-only setting, just like
Agenda View.
FIXED-IN: 5.9.3

Test Plan:
By testing all four combinations for coloring frame and fill
a month item, I confirmed Bug 382185: the color for items with no
categories is used in CategoryOnly as well as in mixed settings (i.e.,
all settings but ResourceOnly). After applying this patch, I tested them
again and confirmed that the unset-category color is only used in
CategoryOnly, while in mixed settings, the resource color is used instead,
making it consistent to Agenda View and the settings dialog.

Reviewers: #kde_pim, dvratil

Reviewed By: #kde_pim, dvratil

Subscribers: dvratil, kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D16088

M  +31   -45   src/month/monthitem.cpp
M  +2    -2    src/month/monthitem.h

https://commits.kde.org/eventviews/0b12580c8e848089a373dadae1c3e12b3ea0a531