The contrast of solarized light is really bad. I noticed it was worse than Konsole's, and then checked and saw that the schema was using a lighter and incorrect normal text color. It should be #657b83. I have no checked other colors to see that they match the latest solarized palette from http://ethanschoonover.com/solarized, but someone should.
I'm working on this now. The colors need a full rework in my opinion so they follow Solarized rules and match the default Vim template.
Please consider creating the themes (also) for the KSyntaxHighlighting framework. In the near future, we will drop the KTextEditor implementation and use the themes from KSyntaxHighlighting only. The work then likely will be lost. See:https://github.com/KDE/syntax-highlighting/tree/master/data/themes
(In reply to Dominik Haumann from comment #2) > Please consider creating the themes (also) for the KSyntaxHighlighting > framework. In the near future, we will drop the KTextEditor implementation > and use the themes from KSyntaxHighlighting only. The work then likely will > be lost. > > See:https://github.com/KDE/syntax-highlighting/tree/master/data/themes Thanks for letting me know. I'm new, so I wasn't aware a migration is occurring. The JSON format there looks simple and matches the fields I'm working out in KTextEditor, so it should be no problem. I'll make sure to create those as well. If you're a reviewer for that, keep an eye out in Phabricator for a patch in the coming days.
Thanks for taking the time to fix this!
(In reply to Michael D from comment #4) > Thanks for taking the time to fix this! Michael, you can check it out here as it goes through code review: https://phabricator.kde.org/D15337
Git commit d67dd570336e995ea4a7f2fbfcd47d05ad3a0eae by Andrew Crouthamel. Committed on 07/09/2018 at 23:25. Pushed by acrouthamel into branch 'master'. Fix Solarized Light and Dark color schemes Summary: Solarized Light contrast was low. Upon investigation it was determined much of the color scheme did not follow Solarized base 16 colors or rules. Color scheme for both Dark and Light variants were adjusted to match the latest Solarized color scheme release palette and [[ https://ethanschoonover.com/solarized/#usage-development | color interaction rules ]]. Color schemes were also matched closely to the [[ https://github.com/altercation/vim-colors-solarized/blob/master/colors/solarized.vim | Vim color scheme ]] created by the original Solarized author. This is my first "frameworks" patch, so please let me know if I missed anything. This has also been added to KSyntaxHighlighting in D15340. Solarized Light Before: {F6241106} Solarized Light After: {F6241107} Solarized Dark Before: {F6241108} Solarized Dark After: {F6241109} Test Plan: Open Kate with new rc files and inspect the Color settings. Open a CPP file to review syntax highlighting. Reviewers: #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann Reviewed By: #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann Subscribers: dhaumann, kwrite-devel, kde-frameworks-devel Tags: #kate, #frameworks, #ktexteditor Differential Revision: https://phabricator.kde.org/D15337 M +9 -9 src/data/kateschemarc M +56 -38 src/data/katesyntaxhighlightingrc https://commits.kde.org/ktexteditor/d67dd570336e995ea4a7f2fbfcd47d05ad3a0eae