Bug 382065 - Weird behavior with smudge brushes and selection
Summary: Weird behavior with smudge brushes and selection
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: 4.0 pre-alpha
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
: 387399 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-07-06 16:12 UTC by radian
Modified: 2018-01-05 08:57 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/krita/1a648228608cc37b469c80ca8a6b8011bac6c7dc
Version Fixed In:
Sentry Crash Report:

Attachments
smudge bugs (1.49 MB, image/gif)
2017-07-06 16:12 UTC, radian 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description radian 2017-07-06 16:12:38 UTC 
Created attachment 106465 [details]
smudge bugs

There is 2 bugs new in 4.0, happens with smudge brushes + selection:

1) brush samples square around brush tip instead of form of brush tip

2) brush can paint outside of selection

See attachment (pressure didn't work while I recorded it but effect is very visible).
Comment 1 Halla Rempt 2017-11-23 10:02:33 UTC 
I can confirm the issue. it was already present in the first development build, too.
Comment 2 Halla Rempt 2017-11-28 14:26:14 UTC 
*** Bug 387399 has been marked as a duplicate of this bug. ***
Comment 3 Dmitry Kazakov 2018-01-05 08:44:32 UTC 
The selection problem happens because the new Alpha color space doesn't support Multiply blending mode.
Comment 4 Dmitry Kazakov 2018-01-05 08:57:20 UTC 
Git commit 1a648228608cc37b469c80ca8a6b8011bac6c7dc by Dmitry Kazakov.
Committed on 05/01/2018 at 08:56.
Pushed by dkazakov into branch 'master'.

Implement Multiply blending mode for alpha color space

It fixes using selection in the colorsmudge brush :)

M  +36   -1    libs/pigment/colorspaces/KoAlphaColorSpace.cpp

https://commits.kde.org/krita/1a648228608cc37b469c80ca8a6b8011bac6c7dc