Bug 381985 - Single line adjustment
Summary: Single line adjustment
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: kwrite (other bugs)
Version First Reported In: 17.04.2
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-04 13:10 UTC by Nicolás Sirolli
Modified: 2019-03-04 18:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolás Sirolli 2017-07-04 13:10:45 UTC
When applying a line adjustment, the editor adjusts the whole document, and not just the line where the cursor is. Yet, it is possible to adjust just a line (or a range of lines) by previously selecting it (them) and then running the line adjustment command.

I wish I could adjust the line I'm working on by just running a command, without need to previously select it.
Comment 1 Christoph Cullmann 2019-03-04 18:12:53 UTC
Git commit 5339a32c12141b6a07c7e6bdd050a06baacc5d81 by Christoph Cullmann, on behalf of loh tar.
Committed on 04/03/2019 at 18:14.
Pushed by cullmann into branch 'master'.

ViewPrivate: Make 'Apply Word Wrap' more comfortable

Summary:
This patch address not all aspects but should be a step in the right direction.

- Don't wrap entire document when nothing is selected but wrap current line
- Join paragraph before wrap to avoid odd result
- Add new function DocumentPrivate::wrapParagraph for that task
- Update 'What's This' hint to reflect new behaviour
- Update 'What's This' hint of dyn wrap too to be more precise

Old Hints
{F6563805}
New Hints
{F6563807}

Test Plan:
My arbitrary chosen test data.

1aaaaa  aaaa aaaa aaaaaaa
2aa aaaaaaa aaaaaa aaaaaaa aaa  aaaa aaaa aaaaaaa aa
3aaaaaaaa aaaaaaa aaaaaaa aaaaaa aaaaaaa aaaaaaaaa aaaaaaaa aaaaaaaa aaaaa aaaaa aaaa aaaa aaaaaaa aa
4aaaaa  aaaa aaaa aaaaaaa aa
5aaa  aaaa aaaa aaaaaaa aa aaaa aaaaaaa aa aaaaaaa

1-----  ---- ---- -------
2-- ------- ------ ------- ---  ---- ---- ------- --
3-------- ------- ------- ------ ------- --------- -------- -------- ----- ----- ---- ---- ------- --
4-----  ---- ---- ------- --
5---  ---- ---- ------- -- ---- ------- -- -------

1xxxxx  xxxx xxxx xxxxxxx
2xx xxxxxxx xxxxxx xxxxxxx xxx  xxxx xxxx xxxxxxx xx
3xxxxxxxx xxxxxxx xxxxxxx xxxxxx xxxxxxx xxxxxxxxx xxxxxxxx xxxxxxxx xxxxx xxxxx xxxx xxxx xxxxxxx xx
4xxxxx  xxxx xxxx xxxxxxx xx
5xxx  xxxx xxxx xxxxxxx xx xxxx xxxxxxx xx xxxxxxx

Before
{F6523470}
With Patch
{F6523471}

Reviewers: #ktexteditor, mwolff, cullmann

Reviewed By: #ktexteditor, cullmann

Subscribers: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D17949

M  +20   -0    autotests/src/katedocument_test.cpp
M  +1    -0    autotests/src/katedocument_test.h
M  +61   -0    src/document/katedocument.cpp
M  +17   -1    src/document/katedocument.h
M  +14   -8    src/view/kateview.cpp
M  +2    -1    src/view/kateview.h

https://commits.kde.org/ktexteditor/5339a32c12141b6a07c7e6bdd050a06baacc5d81