Bug 381982 - SDDM KCM shows session files with Hidden=true
Summary: SDDM KCM shows session files with Hidden=true
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_sddm (show other bugs)
Version: 5.10.3
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-04 11:05 UTC by Koen
Modified: 2017-07-11 11:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot of problem (71.79 KB, image/png)
2017-07-04 11:05 UTC, Koen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Koen 2017-07-04 11:05:36 UTC
Created attachment 106436 [details]
screenshot of problem

See attachment. Where can I fix this?
Comment 1 Fabian Vogt 2017-07-11 10:53:52 UTC
The duplicate "Plasma 5" session is caused by downstream adding a "default.desktop" symlink in /usr/share/xsessions. The sddm kcm does not handle this case, it should probably get shown as "(System Default)" or similar. Anyway, that needs to be fixed downstream first.

I see a second issue though, desktop files with Hidden=true are still shown although the spec says they need to be ignored completely. This part needs to be fixed in kcm_sddm indeed, so setting CONFIRMED and adjusting the subject.
Comment 2 Fabian Vogt 2017-07-11 11:08:50 UTC
(In reply to Fabian Vogt from comment #1)
> I see a second issue though, desktop files with Hidden=true are still shown
> although the spec says they need to be ignored completely. This part needs
> to be fixed in kcm_sddm indeed, so setting CONFIRMED and adjusting the
> subject.

I made a patch for the second issue: https://phabricator.kde.org/D6626
Comment 3 Fabian Vogt 2017-07-11 11:17:33 UTC
Git commit 992143c4bf5ad5219a20cc7c56efea5c941ef79b by Fabian Vogt.
Committed on 11/07/2017 at 11:15.
Pushed by fvogt into branch 'Plasma/5.8'.

Session file parser: Support sections and respect the Hidden property

Summary:
Some desktop files have multiple sections, but for now we're only
interested in [Desktop Entry]. Without this patch, every entry was seen
as part of the [Desktop Entry] session, resulting in values getting
overwritten.

Additionally, the Hidden=true property specifies that the desktop file
needs to be treated like it was non-existant.

Same as https://github.com/sddm/sddm/pull/821 for sddm.

Test Plan:
Installed the KCM, now there are no duplicate sessions and the right
Name is shown for icewm-session.desktop.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6626

M  +20   -2    src/sessionmodel.cpp

https://commits.kde.org/sddm-kcm/992143c4bf5ad5219a20cc7c56efea5c941ef79b
Comment 4 Fabian Vogt 2017-07-11 11:20:39 UTC
Git commit 65dc9de7c45d5ea4affaa6bf9e6601a000c3e321 by Fabian Vogt.
Committed on 11/07/2017 at 11:07.
Pushed by fvogt into branch 'Plasma/5.10'.

Session file parser: Support sections and respect the Hidden property

Summary:
Some desktop files have multiple sections, but for now we're only
interested in [Desktop Entry]. Without this patch, every entry was seen
as part of the [Desktop Entry] session, resulting in values getting
overwritten.

Additionally, the Hidden=true property specifies that the desktop file
needs to be treated like it was non-existant.

Same as https://github.com/sddm/sddm/pull/821 for sddm.

Test Plan:
Installed the KCM, now there are no duplicate sessions and the right
Name is shown for icewm-session.desktop.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6626

M  +20   -2    src/sessionmodel.cpp

https://commits.kde.org/sddm-kcm/65dc9de7c45d5ea4affaa6bf9e6601a000c3e321