Bug 381935 - When copy-pasting a flower shape, the pasted shape is a regular path.
Summary: When copy-pasting a flower shape, the pasted shape is a regular path.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layers/Vector (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-02 19:37 UTC by wolthera
Modified: 2018-02-23 15:16 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description wolthera 2017-07-02 19:37:01 UTC
Probably because it isn't defined as an svg shape?
Comment 1 Quiralta 2017-07-12 17:45:05 UTC
I think that I experience extra symptoms from this bug, the ellipse and rectangle tool's shapes as svg also suffer from this same situation, will paste as the original shape even after they been converted to path and reshaped their nodes.

I also notice that this happens after reopening a document saved with modified shapes, they will revert to its original form.

Shapes created with the bezier curve tool do not suffer from this.

Tried this on git master build also.
Comment 2 Raghavendra kamath 2017-07-13 15:50:12 UTC
I experience this too in latest git master. Confirming this
Comment 3 Dmitry Kazakov 2018-02-23 11:54:06 UTC
Git commit 9986cb1d61042b6579da246cac3eda798242c279 by Dmitry Kazakov.
Committed on 23/02/2018 at 11:53.
Pushed by dkazakov into branch 'master'.

Fix z-index of the pasted shapes

Now all the shapes are pasted to the top of the shapes stack.

M  +0    -50   libs/flake/KoToolProxy.cpp
M  +25   -0    libs/ui/actions/KisPasteActionFactory.cpp

https://commits.kde.org/krita/9986cb1d61042b6579da246cac3eda798242c279
Comment 4 Dmitry Kazakov 2018-02-23 11:56:11 UTC
Nope, wrong commit link. This one is not fixed yet :)
Comment 5 Dmitry Kazakov 2018-02-23 15:16:01 UTC
Git commit 170ab8b433cd629c561536d90f1a0a45018f30e9 by Dmitry Kazakov.
Committed on 23/02/2018 at 15:15.
Pushed by dkazakov into branch 'master'.

Fix copy-paste/save of parameter shapes converted to paths

We should copy the "converted" flag when copying the shape :)

M  +2    -1    libs/flake/KoParameterShape.cpp
M  +4    -2    libs/flake/tools/KoPathTool.cpp
M  +19   -9    libs/flake/tools/PathToolOptionWidget.cpp
M  +1    -0    libs/flake/tools/PathToolOptionWidget.h
M  +3    -0    plugins/flake/pathshapes/ellipse/EllipseShape.cpp
M  +3    -0    plugins/flake/pathshapes/rectangle/RectangleShape.cpp

https://commits.kde.org/krita/170ab8b433cd629c561536d90f1a0a45018f30e9