Bug 381576 - Kirigami global drawer fails to render after selecting an option in "mobile mode"
Summary: Kirigami global drawer fails to render after selecting an option in "mobile m...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: Master
Platform: Arch Linux Linux
: NOR major
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-23 13:30 UTC by Patrick Auernig
Modified: 2017-07-11 15:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Auernig 2017-06-23 13:30:26 UTC
The global drawer does not show up again if you select an option that auto-closes the drawer.

I tested this with Discovery and a basic app with nested Kirigami.Action components.

This could be a major issue, because the user has no way to go back to the inital drawer menu (Only restarting the app fixes this).

Here's a video to visualize the issue better:
https://youtu.be/aivAnKwvHQk
Comment 1 Patrick Auernig 2017-06-23 13:34:35 UTC
Some additional system information:

[Package versions]
Plasma: 5.10.2
Frameworks: 5.35.9
Qt: 5.9.0
Kernel: 4.11.6-1-ARCH 64bit

[Hardware]
Processor: AMD FX-8350
Graphics: AMD Radeon RX 480
Comment 2 Marco Martin 2017-07-03 08:37:13 UTC
Aleix, may also be an issue of Discover?
Comment 3 Aleix Pol 2017-07-03 11:10:39 UTC
Might be. More information would be welcome though. Can you run in from the console and see if there's any error messages? I cannot reproduce the issue here.
Comment 4 Aleix Pol 2017-07-10 17:43:25 UTC
Here's a minimal example:
import org.kde.kirigami 2.0 as Kirigami

Kirigami.ApplicationWindow
{
    globalDrawer: Kirigami.GlobalDrawer {
        modal: true
        actions: [
            Kirigami.Action {
                text: "A"
            },
            Kirigami.Action {
                text: "B"

                Kirigami.Action {
                    text: "C"
                }
            }
        ]
    }
}

It needs to be a modal drawer, it's when the drawer is hidden that everything disappears.
Comment 5 Marco Martin 2017-07-11 15:42:49 UTC
Git commit 0ef403d1b945cdd9f2c57b5d978bed272e62a7ff by Marco Martin.
Committed on 11/07/2017 at 15:41.
Pushed by mart into branch 'master'.

use NumberAnimation instead of XAnimator

it's important those are NumberAnimation and not XAnimators
as while the animation is running the drawer may close, and
the animator would stop when not drawing see

M  +29   -3    src/controls/GlobalDrawer.qml

https://commits.kde.org/kirigami/0ef403d1b945cdd9f2c57b5d978bed272e62a7ff