Bug 381549 - Enabled buttons appears greyed like disabled
Summary: Enabled buttons appears greyed like disabled
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: 3.1.4
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-22 21:14 UTC by Rafael Linux User
Modified: 2018-03-19 19:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Active buttons appears like not active (23.36 KB, image/png)
2017-06-22 21:14 UTC, Rafael Linux User
Details
Capture example (15.44 KB, image/png)
2017-08-09 00:20 UTC, Rafael Linux User
Details
icon visibility on the right use case (26.59 KB, image/png)
2018-01-01 14:57 UTC, Scott Petrovic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Linux User 2017-06-22 21:14:35 UTC
Created attachment 106247 [details]
Active buttons appears like not active

On layers window, "delete" and other buttons appears "greyed" instead in black color, like it were disabled, but they are not. It is confusing, IMHO.

Regards
Comment 1 Scott Petrovic 2017-08-08 21:47:47 UTC
have you been changing your themes. Sometimes when changing themes, some icons get in a weird state. Does it look like that right when Krita loads?
Comment 2 Rafael Linux User 2017-08-09 00:17:59 UTC
(In reply to Scott Petrovic from comment #1)
> have you been changing your themes. Sometimes when changing themes, some
> icons get in a weird state. Does it look like that right when Krita loads?

I think this is not theme related. I made a new capture. You know each icon change his shape when user enable or disable them. In the "view" or "no view" eye icon (left column), this remain black even when disabled. However the "lock" and "alpha" columns change to gray when disabled, despite they indicate clearly if they are enabled or disabled by changing their shape.

So you can see there is a different (and unnecessary and confuse IMHO) way to show "enabled" or "disabled". I think icons should not be showed greyed if they are "clickable". 

It's only my opinion anyway.

Thank you
Comment 3 Rafael Linux User 2017-08-09 00:20:44 UTC
Created attachment 107168 [details]
Capture example

"Show icon" never is greyed when disabled, I think this should be the behaviour for the rest of columns.
Comment 4 Halla Rempt 2017-11-23 10:40:45 UTC
I only see this when switching from a dark to a light color theme. If I then restart, I cannot reproduce.
Comment 5 Rafael Linux User 2017-11-23 20:19:53 UTC
As I told in comment 2 (https://bugs.kde.org/show_bug.cgi?id=381549#c2) to put greyed color is confuse, more for new users, but for me too. I think a change of color is not neccesary. The icons change their shape in each state, so IMHO change their color only adds confusion.
Comment 6 Scott Petrovic 2018-01-01 14:57:38 UTC
Created attachment 109614 [details]
icon visibility on the right use case

@Rafael - Yes. what you see is correct. We went through a lot of different versions of the layers docker design and had a lot of discussion on how things should be based on how artists use layers.

I will put a link below to the layers design discussion, but this is the summary of the decision. The layers docker is designed for people that use a lot of layers. When there are a lot of layers on the screen, it was very difficult to "read" the state all the layers were in if they were all at 100% opacity. Most icons on the right will be disabled, so people seemed to only care about if they were active. Making the inactive icons greyed out made it much easier for people to see the options that were being used.

https://phabricator.kde.org/M11

I attached a picture for you to see the type of scenario artists were bringing up. I only use a couple layers when I paint, but some artists like to use 20+ layers when working.

I can probably can grey out the visibility icon if it is not on, but that is probably the most we are going to be able to do with it unless you work in a way we haven't thought of
Comment 7 Rafael Linux User 2018-01-02 02:43:23 UTC
Happy new year Scott

On first place, thank you for your work and explanations. I use Krita for photo pixel retouch and composition, not using more than 7 to 12 layers usually. So maybe my suggestion is not the best for artists who uses Krita in other ways.
Anyway, I must give you thanks for your efforts to make this docker a little more clear to use for me and new users, so any change in this direction it is to be thankful.

I saw the discussion forum in Phabricator, and I understand the complexity of any change, but my suggestion is more accesibility than usability related, based in questions than some users I invited to use Krita ask me about.

One more time, thank you for your job
Comment 8 Scott Petrovic 2018-03-08 16:39:38 UTC
I did grey out the visibility icon for 4.0 if a layer is not visible, so that should be consistent with the other options now. 

Unless there is a usability issue with how the layers are working, the greyed out/disabled pattern for the layers docker will probably have to remain. We played around with both versions of icons (greyed out vs. showing a different icon) and most artists agreed that the greyed out version was easier to use and "read". 

I am closing this for now. If there are any other issues, feel free to file another ticket.
Comment 9 Rafael Linux User 2018-03-19 19:49:17 UTC
I used long far away PS, then Gimp and finally Krita, and for me it's more difficult to understand the way Krita manage this layer icons, but it's a personal opinion, of course. 

Anyway, thank you sincerely for consider the option.