Bug 381272 - make check on ppc64 doesn't compile test_isa_2_06_partx.c without VSX support
Summary: make check on ppc64 doesn't compile test_isa_2_06_partx.c without VSX support
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 3.13 SVN
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-16 09:31 UTC by Mark Wielaard
Modified: 2017-06-16 09:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wielaard 2017-06-16 09:31:16 UTC
The #ifdef HAS_VSX guard is wrongly placed. It makes the standard include headers not be used. Causing:

gcc -DHAVE_CONFIG_H -I. -I../../..  -I../../.. -I../../../include -I../../../coregrind -I../../../include -I../../../VEX/pub -I../../../VEX/pub -DVGA_ppc64be=1 -DVGO_linux=1 -DVGP_ppc64be_linux=1 -DVGPV_ppc64be_linux_vanilla=1   -Winline -Wall -Wshadow -Wno-long-long -g -fno-stack-protector   -m64  -Winline -Wall -O -g -mregnames  -m64 -DHAS_ALTIVEC   -MT test_isa_2_06_part3-test_isa_2_06_part3.o -MD -MP -MF .deps/test_isa_2_06_part3-test_isa_2_06_part3.Tpo -c -o test_isa_2_06_part3-test_isa_2_06_part3.o `test -f 'test_isa_2_06_part3.c' || echo './'`test_isa_2_06_part3.c
test_isa_2_06_part3.c: In function ‘usage’:
test_isa_2_06_part3.c:1611: warning: implicit declaration of function ‘fprintf’
test_isa_2_06_part3.c:1611: warning: incompatible implicit declaration of built-in function ‘fprintf’
test_isa_2_06_part3.c:1611: error: ‘stderr’ undeclared (first use in this function)
test_isa_2_06_part3.c:1611: error: (Each undeclared identifier is reported only once
test_isa_2_06_part3.c:1611: error: for each function it appears in.)
make[5]: *** [test_isa_2_06_part3-test_isa_2_06_part3.o] Error 1

Moving the #include HAS_VSX below the standard includes makes the tests compile.
Comment 1 Mark Wielaard 2017-06-16 09:33:49 UTC
valgrind svn r16450